From: Gerald Pfeifer <gerald@pfeifer.com>
To: Hans-Peter Nilsson <hp@bitrange.com>,
"Joseph S. Myers" <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, Alexandre Oliva <aoliva@redhat.com>
Subject: Re: test_summary: Only include LAST_UPDATED if it exists.
Date: Sat, 25 Apr 2009 20:15:00 -0000 [thread overview]
Message-ID: <alpine.LSU.1.99.0904252203520.16884@acrux.dbai.tuwien.ac.at> (raw)
In-Reply-To: <Pine.LNX.4.64.0904081724190.11061@digraph.polyomino.org.uk>
On Tue, 7 Apr 2009, Hans-Peter Nilsson wrote:
> No issue with the patch as such (for one, it sounds like the
> right thing for e.g. releases), just curious: how come there's
> no LAST_UPDATED in your source tree?
>
> From the above it sounds like you're checking out sources from
> svn. If you use contrib/gcc_update for that (or with --touch
> later) you'd have a LAST_UPDATED.
My nightly bootstrap basically has been doing
$SVN update --accept working 2>&1
$SVN status 2>&1
contrib/gcc_update --touch
for the last couple of years,without problems. I had a look at the
source of gcc_update and don't see --touch modify LAST_UPDATED. And
I don't think it should?
On Wed, 8 Apr 2009, Joseph S. Myers wrote:
>> -# (C) 1998, 1999, 2000, 2002 Free Software Foundation
>> +# (C) 1998, 1999, 2000, 2002, 2003, 2004, 2003, 2004, 2007, 2009
> This now has "2003, 2004" duplicated.
Good catch, Joseph. From none to twice was a bit over eager. :-)
I applied the slightly updated patch below.
Gerald
2009-04-25 Gerald Pfeifer <gerald@pfeifer.com>
* test_summary: Only include LAST_UPDATED if it exists.
Complete copyright years.
Index: test_summary
===================================================================
--- test_summary (revision 146777)
+++ test_summary (working copy)
@@ -1,6 +1,7 @@
#! /bin/sh
-# (C) 1998, 1999, 2000, 2002 Free Software Foundation
+# (C) 1998, 1999, 2000, 2002, 2003, 2004, 2007, 2009
+# Free Software Foundation
# Originally by Alexandre Oliva <oliva@dcc.unicamp.br>
# This script is Free Software, and it can be copied, distributed and
@@ -106,9 +107,11 @@
sub(/^s,@TOPLEVEL_CONFIGURE_ARGUMENTS@,/, "", configflags);
srcdir = configflags;
sub(/\/configure .*/, "", srcdir);
- printf "LAST_UPDATED: ";
- system("tail -1 " srcdir "/LAST_UPDATED");
- print "";
+ if ( system("test -f " srcdir "/LAST_UPDATED") == 0 ) {
+ printf "LAST_UPDATED: ";
+ system("tail -1 " srcdir "/LAST_UPDATED");
+ print "";
+ }
sub(/^[^ ]*\/configure */, " ", configflags);
sub(/,;t t $/, " ", configflags);
next prev parent reply other threads:[~2009-04-25 20:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 14:17 Gerald Pfeifer
2009-04-07 15:33 ` Hans-Peter Nilsson
2009-04-08 17:24 ` Joseph S. Myers
2009-04-25 20:15 ` Gerald Pfeifer [this message]
2009-04-25 21:48 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.1.99.0904252203520.16884@acrux.dbai.tuwien.ac.at \
--to=gerald@pfeifer.com \
--cc=aoliva@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@bitrange.com \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).