From: Richard Biener <rguenther@suse.de>
To: gcc-patches@gcc.gnu.org
Cc: law@redhat.com
Subject: [PATCH] Fix parts of PR61607
Date: Wed, 25 Jun 2014 14:07:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.11.1406251602360.29270@zhemvz.fhfr.qr> (raw)
This removes restrictions in DOM cprop_operand that inhibit
some optimizations. The volatile pointer thing is really realy
old and no longer necessary while the loop-depth consideration
is only valid for loop-closed PHI nodes (but we're not in
loop-closed SSA in DOM) - the coalescing is handled in out-of-SSA
phase by inserting copies appropriately.
Bootstrapped on x86_64-unknown-linux-gnu, ok?
Thanks,
Richard.
2014-06-25 Richard Biener <rguenther@suse.de>
PR tree-optimization/61607
* tree-ssa-dom.c (cprop_operand): Remove restriction on
propagating volatile pointers and on loop depth.
Index: gcc/tree-ssa-dom.c
===================================================================
--- gcc/tree-ssa-dom.c (revision 211969)
+++ gcc/tree-ssa-dom.c (working copy)
@@ -2247,22 +2247,6 @@ cprop_operand (gimple stmt, use_operand_
if (!may_propagate_copy (op, val))
return;
- /* Do not propagate addresses that point to volatiles into memory
- stmts without volatile operands. */
- if (POINTER_TYPE_P (TREE_TYPE (val))
- && TYPE_VOLATILE (TREE_TYPE (TREE_TYPE (val)))
- && gimple_has_mem_ops (stmt)
- && !gimple_has_volatile_ops (stmt))
- return;
-
- /* Do not propagate copies if the propagated value is at a deeper loop
- depth than the propagatee. Otherwise, this may move loop variant
- variables outside of their loops and prevent coalescing
- opportunities. If the value was loop invariant, it will be hoisted
- by LICM and exposed for copy propagation. */
- if (loop_depth_of_name (val) > loop_depth_of_name (op))
- return;
-
/* Do not propagate copies into simple IV increment statements.
See PR23821 for how this can disturb IV analysis. */
if (TREE_CODE (val) != INTEGER_CST
next reply other threads:[~2014-06-25 14:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 14:07 Richard Biener [this message]
2014-06-25 18:28 ` Jeff Law
2014-06-26 7:57 ` Richard Biener
2014-06-26 8:33 ` Richard Biener
2014-06-26 9:01 ` Richard Biener
2014-06-26 15:33 ` Jeff Law
2014-06-25 14:09 Richard Biener
2014-06-25 18:34 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.1406251602360.29270@zhemvz.fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).