From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27344 invoked by alias); 10 Jul 2014 23:29:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 27301 invoked by uid 89); 10 Jul 2014 23:29:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: ainaz.pair.com Received: from ainaz.pair.com (HELO ainaz.pair.com) (209.68.2.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 10 Jul 2014 23:29:18 +0000 Received: from [192.168.0.131] (vie-188-118-252-235.dsl.sil.at [188.118.252.235]) by ainaz.pair.com (Postfix) with ESMTPSA id 328C83F4BD; Thu, 10 Jul 2014 19:29:14 -0400 (EDT) Date: Thu, 10 Jul 2014 23:29:00 -0000 From: Gerald Pfeifer To: Jakub Jelinek cc: Jason Merrill , "Joseph S. Myers" , =?ISO-8859-15?Q?Manuel_L=F3pez-Ib=E1=F1ez?= , Gcc Patch List , Richard Biener , Siddhesh Poyarekar , Carlos O'Donell , GNU C Library Subject: Re: [PATCH] -Wmemset-transposed-args (PR middle-end/61294, take 2) In-Reply-To: <20140710125222.GI31640@tucnak.redhat.com> Message-ID: References: <53BDB402.20309@redhat.com> <20140710125222.GI31640@tucnak.redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00745.txt.bz2 On Thu, 10 Jul 2014, Jakub Jelinek wrote: > +Wmemset-transposed-args > +C ObjC C++ ObjC++ Var(warn_memset_transposed_args) Warning LangEnabledBy(C ObjC C++ ObjC++,Wall) > +Warn about suspicious call to memset where the third argument is constant zero and second is not zero "calls" (plural), like in the .texi documentation? "and the second" (If you want to keep it short, you could say "the third argument is constant zero and the second is not".) > +Warn for suspicious calls to the memset built-in function, if the Should this be @code{memset} as well? > +second argument is not zero and third argument is zero. This warns e.g.@ "the third argument" > +about @code{memset (buf, sizeof buf, 0);} where most probably > +@code{memset (buf, 0, sizeof buf);} was meant instead. I believe this will look better without the semicolons. Gerald