public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <rguenther@suse.de>
To: Bernd Schmidt <bernds_cb1@t-online.de>
Cc: Jan Hubicka <hubicka@ucw.cz>,
	gcc-patches@gcc.gnu.org,
	    "Joseph S. Myers" <joseph@codesourcery.com>,
	    Thomas Schwinge <thomas_schwinge@mentor.com>,
	    Julian Brown <julian@codesourcery.com>,
	    Cesar Philippidis <cesar_philippidis@mentor.com>
Subject: Re: LTO streaming of TARGET_OPTIMIZE_NODE
Date: Thu, 20 Nov 2014 13:38:00 -0000	[thread overview]
Message-ID: <alpine.LSU.2.11.1411201420370.374@zhemvz.fhfr.qr> (raw)
In-Reply-To: <546DDE1C.6060203@t-online.de>

On Thu, 20 Nov 2014, Bernd Schmidt wrote:

> On 11/13/2014 05:06 AM, Jan Hubicka wrote:
> > this patch adds infrastructure for proper streaming and merging of
> > TREE_TARGET_OPTION.
> 
> This breaks the offloading path via LTO since it introduces an incompatibility
> in LTO format between host and offload machine.
> 
> A very quick patch to fix it is below - the OpenACC testcase I was using seems
> to be working again with this. Thoughts, suggestions?

The offload target needs to have the same target options as the host?

Are the offload functions marked somehow?  That is, can we avoid
setting TREE_TARGET_OPTION on them?  Or rather we need to have a
default TREE_TARGET_OPTION node for the offload target which we'd
need to set - how would you otherwise transfer different offload
target options to the offload compile?  How do you transfer
offload target options to the offload compile at all?

I think this just shows conceptual issues with the LTO approach...

Thanks,
Richard.

  reply	other threads:[~2014-11-20 13:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-13  5:10 Jan Hubicka
2014-11-13 10:58 ` Richard Biener
2014-11-13 15:32   ` Jan Hubicka
2014-11-14  0:54     ` Jan Hubicka
2014-11-14  8:54       ` Richard Biener
2014-11-14 18:15       ` [BUILDROBOT] error: ‘cl_target_option_stream_in’ was not declared in this scope (was: LTO streaming of TARGET_OPTIMIZE_NODE) Jan-Benedict Glaw
2014-11-14 19:13         ` [BUILDROBOT] error: �??cl_target_option_stream_in�?? " Jan Hubicka
2014-11-15 17:07           ` Jan-Benedict Glaw
2014-11-20 13:09 ` LTO streaming of TARGET_OPTIMIZE_NODE Bernd Schmidt
2014-11-20 13:38   ` Richard Biener [this message]
2014-11-20 14:24     ` Bernd Schmidt
2014-11-20 21:51       ` Jan Hubicka
2015-01-08 14:12   ` Jakub Jelinek
2015-01-09 11:13     ` Thomas Schwinge
2015-01-09 11:50       ` Jakub Jelinek
2015-01-09 12:12         ` Richard Biener
2015-01-11 17:38         ` Jan Hubicka
2015-01-11 21:28         ` Ilya Verbin
2015-01-12 20:08           ` Jan Hubicka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.11.1411201420370.374@zhemvz.fhfr.qr \
    --to=rguenther@suse.de \
    --cc=bernds_cb1@t-online.de \
    --cc=cesar_philippidis@mentor.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    --cc=joseph@codesourcery.com \
    --cc=julian@codesourcery.com \
    --cc=thomas_schwinge@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).