From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13804 invoked by alias); 20 Nov 2014 13:26:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 13794 invoked by uid 89); 20 Nov 2014 13:26:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx2.suse.de Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 20 Nov 2014 13:26:53 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id EECAAAC24; Thu, 20 Nov 2014 13:26:50 +0000 (UTC) Date: Thu, 20 Nov 2014 13:38:00 -0000 From: Richard Biener To: Bernd Schmidt cc: Jan Hubicka , gcc-patches@gcc.gnu.org, "Joseph S. Myers" , Thomas Schwinge , Julian Brown , Cesar Philippidis Subject: Re: LTO streaming of TARGET_OPTIMIZE_NODE In-Reply-To: <546DDE1C.6060203@t-online.de> Message-ID: References: <20141113040652.GB1984@kam.mff.cuni.cz> <546DDE1C.6060203@t-online.de> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2014-11/txt/msg02664.txt.bz2 On Thu, 20 Nov 2014, Bernd Schmidt wrote: > On 11/13/2014 05:06 AM, Jan Hubicka wrote: > > this patch adds infrastructure for proper streaming and merging of > > TREE_TARGET_OPTION. > > This breaks the offloading path via LTO since it introduces an incompatibility > in LTO format between host and offload machine. > > A very quick patch to fix it is below - the OpenACC testcase I was using seems > to be working again with this. Thoughts, suggestions? The offload target needs to have the same target options as the host? Are the offload functions marked somehow? That is, can we avoid setting TREE_TARGET_OPTION on them? Or rather we need to have a default TREE_TARGET_OPTION node for the offload target which we'd need to set - how would you otherwise transfer different offload target options to the offload compile? How do you transfer offload target options to the offload compile at all? I think this just shows conceptual issues with the LTO approach... Thanks, Richard.