From: Richard Biener <rguenther@suse.de>
To: Marek Polacek <polacek@redhat.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
Tom de Vries <Tom_deVries@mentor.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Michael Matz <matz@suse.de>
Subject: Re: [PATCH][2/5] Add gimple_find_sub_bbs
Date: Thu, 19 Feb 2015 13:31:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.11.1502191408050.28824@zhemvz.fhfr.qr> (raw)
In-Reply-To: <20150219125914.GA23138@redhat.com>
On Thu, 19 Feb 2015, Marek Polacek wrote:
> On Thu, Feb 19, 2015 at 01:48:58PM +0100, Jakub Jelinek wrote:
> > On Thu, Feb 19, 2015 at 01:41:05PM +0100, Richard Biener wrote:
> > > I hope we can get rid of this again (which needs re-writing of all
> > > targets va-arg gimplification hooks... - we are in need of some
> > > generic diamond/triangle CFG pattern builders anyway).
> >
> > We already have some in asan.c - create_cond_insert_point - perhaps
> > it isn't best named and could use some changes to be generally usable.
>
> Yeah, create_cond_insert_point is used in ubsan.c many times, and
> there's nothing *san specific in it.
It's also quite low-level. I'm more looking for sth like
val = gimple_build_cond_value (EQ_EXPR, comp_lhs, comp_rhs,
true_value, true_gimple_seq,
false_value, false_gimple_seq);
which then returns a simplified value (in case all is optimizable
to a constant for example) or produces
if (comp_lhs == comp_rhs)
true_gimple_seq;
else
false_gimple_seq;
val = PHI <true_value, false_value>
so basically allows you to build the true/false values with
gimple_build (or force_gimple_operand for legacy code) and
constructs the diamond/triangle and a PHI together with the
controlling predicate.
Richard.
next prev parent reply other threads:[~2015-02-19 13:12 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 10:48 [stage1] Postpone expanding va_arg until pass_stdarg Tom de Vries
2015-02-19 10:51 ` [PATCH][1/5] Disable lang_hooks.gimplify_expr in free_lang_data Tom de Vries
2015-02-19 12:41 ` Richard Biener
2015-02-19 10:59 ` [PATCH][2/5] Add gimple_find_sub_bbs Tom de Vries
2015-02-19 12:41 ` Richard Biener
2015-02-19 12:51 ` Jakub Jelinek
2015-02-19 13:03 ` Marek Polacek
2015-02-19 13:31 ` Richard Biener [this message]
2015-02-19 13:07 ` Richard Biener
2015-02-22 12:47 ` Tom de Vries
2015-02-19 11:06 ` [PATCH][3/5] Factor optimize_va_list_gpr_fpr_size out of pass_stdarg::execute Tom de Vries
2015-02-19 12:44 ` Richard Biener
2015-02-19 11:37 ` [PATCH][4/5] Handle internal_fn in operand_equal_p Tom de Vries
2015-02-19 12:49 ` Richard Biener
2015-02-19 12:59 ` Jakub Jelinek
2015-02-19 13:09 ` Richard Biener
2015-02-19 15:31 ` Tom de Vries
2015-02-20 11:59 ` Richard Biener
2015-02-22 13:13 ` Tom de Vries
2015-02-23 10:19 ` Richard Biener
2015-02-24 13:09 ` Fwd: " Tom de Vries
2015-02-19 12:08 ` [PATCH][5/5] Postpone expanding va_arg until pass_stdarg Tom de Vries
2015-02-19 13:05 ` Richard Biener
2015-02-22 13:24 ` Tom de Vries
2015-02-23 9:03 ` Michael Matz
2015-02-23 10:36 ` Tom de Vries
2015-02-24 8:26 ` Tom de Vries
2015-03-10 15:31 ` [PING] [PATCH][5b/5] Avoid running expand_ifn_va_arg_1 in functions without va_arg Tom de Vries
2015-04-16 8:50 ` [PING^2] " Tom de Vries
2015-04-16 8:56 ` Richard Biener
2015-03-10 15:31 ` [PING] [PATCH][5a/5] Postpone expanding va_arg until pass_stdarg Tom de Vries
2015-04-16 8:50 ` [PING^2] " Tom de Vries
2015-04-16 8:55 ` Richard Biener
2015-04-21 5:32 ` Bin.Cheng
2015-06-09 11:04 ` Alan Lawrence
2015-06-09 11:07 ` Richard Biener
2015-06-09 13:03 ` Tom de Vries
2015-06-09 13:07 ` Richard Biener
2015-06-09 13:30 ` Alan Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.1502191408050.28824@zhemvz.fhfr.qr \
--to=rguenther@suse.de \
--cc=Tom_deVries@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=matz@suse.de \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).