public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <rguenther@suse.de>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Silence merge warnings on artiical types
Date: Mon, 30 Mar 2015 08:30:00 -0000	[thread overview]
Message-ID: <alpine.LSU.2.11.1503301029261.31545@zhemvz.fhfr.qr> (raw)
In-Reply-To: <20150330030257.GA71352@kam.mff.cuni.cz>

On Mon, 30 Mar 2015, Jan Hubicka wrote:

> Hi,
> when compiling C++ program that define different number of virtual method
> in different classes, we output warnings about their virtual tables
> being of different type. THese warnings looks ugly and we are able
> to diagnose the situation in more sensible way.
> 
> This patch simply silences all warnings on artificial decls.
> 
> Bootstrapped/regtested x86_64-linux OK?

Hum...  but do ODR warnings cover all other cases here?  Well,
the warnings won't be useful to users I suppose.

Thus, ok.

Thanks,
Richard.

> Honza
> 
> 	* lto-symtab.c (lto_symtab_merge_decls_2): Silence warnings on
> 	artificial decls.
> Index: lto/lto-symtab.c
> ===================================================================
> --- lto/lto-symtab.c	(revision 221757)
> +++ lto/lto-symtab.c	(working copy)
> @@ -473,7 +473,8 @@ lto_symtab_merge_decls_2 (symtab_node *f
>      if (TREE_PUBLIC (e->decl))
>        {
>  	if (!lto_symtab_merge (prevailing, e)
> -	    && !diagnosed_p)
> +	    && !diagnosed_p
> +	    && !DECL_ARTIFICIAL (e->decl))
>  	  mismatches.safe_push (e->decl);
>        }
>    if (mismatches.is_empty ())
> 
> 

-- 
Richard Biener <rguenther@suse.de>
SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Jennifer Guild,
Dilip Upmanyu, Graham Norton HRB 21284 (AG Nuernberg)

  reply	other threads:[~2015-03-30  8:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30  3:03 Jan Hubicka
2015-03-30  8:30 ` Richard Biener [this message]
2015-03-30  8:48   ` Jan Hubicka
2015-03-30 15:36 ` Ilya Verbin
2015-03-30 17:06   ` Jan Hubicka
2015-03-30 17:11     ` Ilya Verbin
2015-03-30 17:16       ` Jan Hubicka
2015-03-30 17:21     ` Jakub Jelinek
2015-03-30 17:23       ` Jan Hubicka
2015-03-30 17:53         ` Jason Merrill
2015-03-31  7:51           ` Silence merge warnings on artificial types Jan Hubicka
2015-03-31 13:26             ` Jason Merrill
2015-04-02 18:23             ` Ilya Verbin
2015-04-02 18:37               ` Jan Hubicka
2015-04-02 19:06               ` Jakub Jelinek
2015-04-03 13:36                 ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.11.1503301029261.31545@zhemvz.fhfr.qr \
    --to=rguenther@suse.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).