From: Richard Biener <rguenther@suse.de>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH] Fix(?) PR66002
Date: Mon, 04 May 2015 14:18:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.11.1505041615450.20496@zhemvz.fhfr.qr> (raw)
This fixes a missed vectorization of a function in paq8p. Without
merged PHI nodes phiopt doesn't recognize adjacent MIN/MAX_EXPRs.
Certainly no other pass I schedule mergephi over cares for merged
PHIs (DCE might even be confused here).
Bootstrap and regtest running on x86_64-unknown-linux-gnu.
Richard.
2015-05-04 Richard Biener <rguenther@suse.de>
PR tree-optimization/66002
* passes.def: Schedule pass_merge_phi after VRP, right before
ifcombine and phiopt.
* gcc.dg/vect/vect-125.c: New testcase.
Index: gcc/passes.def
===================================================================
*** gcc/passes.def (revision 222760)
--- gcc/passes.def (working copy)
*************** along with GCC; see the file COPYING3.
*** 168,174 ****
NEXT_PASS (pass_build_alias);
NEXT_PASS (pass_return_slot);
NEXT_PASS (pass_fre);
- NEXT_PASS (pass_merge_phi);
NEXT_PASS (pass_vrp);
NEXT_PASS (pass_chkp_opt);
NEXT_PASS (pass_dce);
--- 168,173 ----
*************** along with GCC; see the file COPYING3.
*** 176,181 ****
--- 175,181 ----
NEXT_PASS (pass_call_cdce);
NEXT_PASS (pass_cselim);
NEXT_PASS (pass_copy_prop);
+ NEXT_PASS (pass_merge_phi);
NEXT_PASS (pass_tree_ifcombine);
NEXT_PASS (pass_phiopt);
NEXT_PASS (pass_tail_recursion);
Index: gcc/testsuite/gcc.dg/vect/vect-125.c
===================================================================
*** gcc/testsuite/gcc.dg/vect/vect-125.c (revision 0)
--- gcc/testsuite/gcc.dg/vect/vect-125.c (working copy)
***************
*** 0 ****
--- 1,19 ----
+ /* { dg-do compile } */
+ /* { dg-require-effective-target vect_int } */
+ /* { dg-require-effective-target vect_pack_trunc } */
+ /* { dg-require-effective-target vect_unpack } */
+
+ void train(short *t, short *w, int n, int err)
+ {
+ n=(n+7)&-8;
+ for (int i=0; i<n; ++i)
+ {
+ int wt=w[i]+((t[i]*err*2>>16)+1>>1);
+ if (wt<-32768) wt=-32768;
+ if (wt>32767) wt=32767;
+ w[i]=wt;
+ }
+ }
+
+ /* { dg-final { scan-tree-dump "vectorized 1 loops" "vect" { xfail vect_no_int_max } } } */
+ /* { dg-final { cleanup-tree-dump "vect" } } */
next reply other threads:[~2015-05-04 14:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 14:18 Richard Biener [this message]
2015-05-07 9:51 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.1505041615450.20496@zhemvz.fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).