From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129194 invoked by alias); 9 Jun 2015 12:22:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 129182 invoked by uid 89); 9 Jun 2015 12:22:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,KAM_ASCII_DIVIDERS,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx2.suse.de Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 09 Jun 2015 12:22:50 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id B1FD1AD14 for ; Tue, 9 Jun 2015 12:22:47 +0000 (UTC) Date: Tue, 09 Jun 2015 12:32:00 -0000 From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] Fix PR66423 Message-ID: User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2015-06/txt/msg00658.txt.bz2 Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2015-06-09 Richard Biener PR middle-end/66423 * match.pd: Handle A % (unsigned)(1 << B). * gcc.dg/fold-modpow2.c: New testcase. Index: gcc/match.pd =================================================================== *** gcc/match.pd (revision 224271) --- gcc/match.pd (working copy) *************** (define_operator_list swapped_tcc_compar *** 248,258 **** (lshift INTEGER_CST@1 @2)) (for mod (trunc_mod floor_mod) (simplify ! (mod @0 (power_of_two_cand@1 @2)) (if ((TYPE_UNSIGNED (type) || tree_expr_nonnegative_p (@0)) && integer_pow2p (@2) && tree_int_cst_sgn (@2) > 0) ! (bit_and @0 (minus @1 { build_int_cst (TREE_TYPE (@1), 1); }))))) /* X % Y is smaller than Y. */ (for cmp (lt ge) --- 248,259 ---- (lshift INTEGER_CST@1 @2)) (for mod (trunc_mod floor_mod) (simplify ! (mod @0 (convert?@3 (power_of_two_cand@1 @2))) (if ((TYPE_UNSIGNED (type) || tree_expr_nonnegative_p (@0)) + && tree_nop_conversion_p (type, TREE_TYPE (@3)) && integer_pow2p (@2) && tree_int_cst_sgn (@2) > 0) ! (bit_and @0 (convert (minus @1 { build_int_cst (TREE_TYPE (@1), 1); })))))) /* X % Y is smaller than Y. */ (for cmp (lt ge) Index: gcc/testsuite/gcc.dg/fold-modpow2.c =================================================================== *** gcc/testsuite/gcc.dg/fold-modpow2.c (revision 0) --- gcc/testsuite/gcc.dg/fold-modpow2.c (working copy) *************** *** 0 **** --- 1,11 ---- + /* { dg-do compile } */ + /* { dg-options "-fdump-tree-original" } */ + + unsigned int + my_mod (unsigned int a, unsigned int b) + { + return a % (1 << b); + } + + /* The above should be simplified to (unsigned int) ((1 << b) + -1) & a */ + /* { dg-final { scan-tree-dump "& a;" "original" } } */