From: Richard Biener <rguenther@suse.de>
To: Pierre-Marie de Rodat <derodat@adacore.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][PR debug/65549] Restore DW_AT_abstract_origin for cross-unit call sites
Date: Thu, 11 Jun 2015 08:02:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.11.1506110945560.14687@zhemvz.fhfr.qr> (raw)
In-Reply-To: <55784A03.2000208@adacore.com>
On Wed, 10 Jun 2015, Pierre-Marie de Rodat wrote:
> On 06/10/2015 03:36 PM, Richard Biener wrote:
> > Hmm, yes. It meant to break after the first ;) (without LTO
> > there usually is only one TU decl, apart from Java I think).
> > The hunk isn't in mainline because it was part of an experimental patch I
> > did on the early-debug branch.
>
> Understood, thanks!
>
> > Yeah, that looks great!
> >
> > Of course I wonder about Java (builds multiple ones, one for each
> > input file) and Go (no idea). I suppose Java would need to build
> > another one where all the "defaults" go (or it doesn't have any
> > such entities).
>
> Yeah, I'm not familiar with them neither...
>
> > In theory we could have changed dwarf2out_init to get a
> > translation-unit-decl argument as well. But your patch looks like
> > we don't have such at the point of dwarf2out_init in all frontends.
> >
> > Your patch is ok (and ok to backport) IMHO, though please give
> > others the chance to chime in.
>
> Thank you very much. :-) I will soon become unavailable until July, so I think
> I'll wait until then to commit anyway.
Ok - can you please open a bugreport for the regression on the 4.9
branch so we don't miss the fix for the next 4.9 release which should
be in about 3 weeks from now (in fact you might miss the RC deadline
for that release).
So I suggest you commit the patch to trunk this week so others can
take care of backporting.
Thanks,
Richard.
--
Richard Biener <rguenther@suse.de>
SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Dilip Upmanyu, Graham Norton, HRB 21284 (AG Nuernberg)
next prev parent reply other threads:[~2015-06-11 7:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 21:39 Pierre-Marie de Rodat
2015-06-10 7:06 ` Richard Biener
2015-06-10 13:09 ` Pierre-Marie de Rodat
2015-06-10 13:37 ` Richard Biener
2015-06-10 14:31 ` Pierre-Marie de Rodat
2015-06-11 8:02 ` Richard Biener [this message]
2015-06-11 9:10 ` Richard Biener
2015-06-11 9:21 ` Pierre-Marie de Rodat
2015-06-11 9:25 ` Richard Biener
2015-06-11 13:49 ` Pierre-Marie de Rodat
2015-06-12 1:25 David Edelsohn
2015-06-12 5:45 ` Richard Biener
2015-06-12 10:15 ` Pierre-Marie de Rodat
2015-06-12 10:32 ` Pierre-Marie de Rodat
2015-06-12 11:17 ` Richard Biener
2015-06-12 13:56 ` Pierre-Marie de Rodat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.1506110945560.14687@zhemvz.fhfr.qr \
--to=rguenther@suse.de \
--cc=derodat@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).