From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31099 invoked by alias); 11 Jun 2015 07:48:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 31089 invoked by uid 89); 11 Jun 2015 07:48:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx2.suse.de Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 11 Jun 2015 07:48:02 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 9E42EAAB4; Thu, 11 Jun 2015 07:47:58 +0000 (UTC) Date: Thu, 11 Jun 2015 08:02:00 -0000 From: Richard Biener To: Pierre-Marie de Rodat cc: GCC Patches Subject: Re: [PATCH][PR debug/65549] Restore DW_AT_abstract_origin for cross-unit call sites In-Reply-To: <55784A03.2000208@adacore.com> Message-ID: References: <55775CDE.2060101@adacore.com> <55783717.8060505@adacore.com> <55784A03.2000208@adacore.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2015-06/txt/msg00803.txt.bz2 On Wed, 10 Jun 2015, Pierre-Marie de Rodat wrote: > On 06/10/2015 03:36 PM, Richard Biener wrote: > > Hmm, yes. It meant to break after the first ;) (without LTO > > there usually is only one TU decl, apart from Java I think). > > The hunk isn't in mainline because it was part of an experimental patch I > > did on the early-debug branch. > > Understood, thanks! > > > Yeah, that looks great! > > > > Of course I wonder about Java (builds multiple ones, one for each > > input file) and Go (no idea). I suppose Java would need to build > > another one where all the "defaults" go (or it doesn't have any > > such entities). > > Yeah, I'm not familiar with them neither... > > > In theory we could have changed dwarf2out_init to get a > > translation-unit-decl argument as well. But your patch looks like > > we don't have such at the point of dwarf2out_init in all frontends. > > > > Your patch is ok (and ok to backport) IMHO, though please give > > others the chance to chime in. > > Thank you very much. :-) I will soon become unavailable until July, so I think > I'll wait until then to commit anyway. Ok - can you please open a bugreport for the regression on the 4.9 branch so we don't miss the fix for the next 4.9 release which should be in about 3 weeks from now (in fact you might miss the RC deadline for that release). So I suggest you commit the patch to trunk this week so others can take care of backporting. Thanks, Richard. -- Richard Biener SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Dilip Upmanyu, Graham Norton, HRB 21284 (AG Nuernberg)