From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10957 invoked by alias); 24 Jun 2015 07:10:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 10936 invoked by uid 89); 24 Jun 2015 07:10:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx2.suse.de Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 24 Jun 2015 07:10:45 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 2D469AC6B; Wed, 24 Jun 2015 07:10:41 +0000 (UTC) Date: Wed, 24 Jun 2015 07:55:00 -0000 From: Richard Biener To: James Greenhalgh cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH][testsuite] Fix TORTURE_OPTIONS overriding In-Reply-To: <1435077660-14023-1-git-send-email-james.greenhalgh@arm.com> Message-ID: References: <93598EAE-787F-42AC-BF98-EFC1A868DB46@comcast.net> <1435077660-14023-1-git-send-email-james.greenhalgh@arm.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2015-06/txt/msg01665.txt.bz2 On Tue, 23 Jun 2015, James Greenhalgh wrote: > > On Thu, Jun 18, 2015 at 11:10:01AM +0100, Richard Biener wrote: > > > > Currently when doing > > > > make check-gcc RUNTESTFLAGS="TORTURE_OPTIONS=\\\"{ -O3 } { -O2 }\\\" > > dg-torture.exp" > > > > you get -O3 and -O2 but also the two LTO torture option combinations. > > That's undesired (those are the most expensive anyway). The following > > patch avoids this by setting LTO_TORTURE_OPTIONS only when > > TORTURE_OPTIONS isn't specified. > > > > Tested with and without TORTURE_OPTIONS for C and fortran tortures. > > > > Seems the instruction in c-torture.exp how to override TORTURE_OPTIONS > > is off, RUNTESTFLAGS="TORTURE_OPTIONS=\\\"{ { -O3 } { -O2 } }\\\" > > certainly doesn't do what it should. > > This patch causes issues for ARM and AArch64 cross multilib > testing. There are two issues, one is that we now clobber > gcc_force_conventional_output after setting it in the conditional this patch > moved (hits all targets, see the new x86-64 failures like pr61848.c). > > The other is that we no longer protect environment settings before calling > check_effective_target_lto, which results in our cross --specs files no > longer being on the path. > > I've fixed these issues by rearranging the file again, but I'm not > sure if what I've done is sensible and does not cause other issues. This > seems to bring back the tests I'd lost overnight, and doesn't cause > issues elsewhere. > > I've run some cross-tests to ensure this brings back the missing tests, > and a full x86-64 testrun to make sure I haven't dropped any from there. > > OK for trunk? Ok. Thanks, Richard. > Thanks, > James > > --- > 2015-06-23 James Greenhalgh > > * lib/c-torture.exp: Don't call check_effective_target_lto > before setting up environment correctly. > * lib/gcc-dg.exp: Likewise, and protect > gcc_force_conventional_output. > > -- Richard Biener SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Dilip Upmanyu, Graham Norton, HRB 21284 (AG Nuernberg)