From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40296 invoked by alias); 11 Aug 2015 11:30:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 40247 invoked by uid 89); 11 Aug 2015 11:30:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 11 Aug 2015 11:30:22 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 9CDDAAD52; Tue, 11 Aug 2015 11:30:18 +0000 (UTC) Date: Tue, 11 Aug 2015 11:30:00 -0000 From: Richard Biener To: Nathan Sidwell cc: GCC Patches Subject: Re: [optimize 1/3] Fix phi to min/max In-Reply-To: <55C91734.4010602@acm.org> Message-ID: References: <55C91734.4010602@acm.org> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2015-08/txt/msg00508.txt.bz2 On Mon, 10 Aug 2015, Nathan Sidwell wrote: > Richard, > > This patch fixes the problem I described earlier about min/max generation > propagating incorrect range information > (https://gcc.gnu.org/ml/gcc/2015-08/msg00024.html). > > I went with creating a new name, if the PHI being modified has more than 2 > edges. I also modified the testcase that my min/max vrp patch tickled -- it > wasn't calling an init function and hence copying zeroes rather than the small > values it thought it was copying. Also added a new test to convert zeroes, > which was the failure mode I observed in the DFP lib. > > This patch was tested in combination with the new min max optimization I'll > post momentarily. > > ok? Ok. Thanks, Richard.