From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130070 invoked by alias); 12 Aug 2015 10:06:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 130061 invoked by uid 89); 12 Aug 2015 10:06:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 12 Aug 2015 10:06:22 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41515) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ZPSvM-0008VK-4f for gcc-patches@gnu.org; Wed, 12 Aug 2015 06:06:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPSvI-0003oL-A7 for gcc-patches@gnu.org; Wed, 12 Aug 2015 06:06:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:59875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPSvI-0003n6-3Z for gcc-patches@gnu.org; Wed, 12 Aug 2015 06:06:16 -0400 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 720DAAAC8; Wed, 12 Aug 2015 10:06:14 +0000 (UTC) Date: Wed, 12 Aug 2015 10:06:00 -0000 From: Richard Biener To: Rainer Orth cc: Tom de Vries , "gcc-patches@gnu.org" Subject: Re: [RFC] Add check_effective_target_vect_min_max In-Reply-To: Message-ID: References: <55CAE044.9040006@mentor.com> <55CAE8FA.1020504@mentor.com> <55CB0E85.3020403@mentor.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 195.135.220.15 X-SW-Source: 2015-08/txt/msg00580.txt.bz2 On Wed, 12 Aug 2015, Rainer Orth wrote: > Tom de Vries writes: > > > On 12/08/15 10:51, Rainer Orth wrote: > >> Tom de Vries writes: > >> > >>> This follow-up patch introduces a new effective target vect_min_max, > >>> similar to how effective target vect_bswap is implemented. > >>> > >>> Any comments? > >>> > >>> Thanks, > >>> - Tom > >>> > >>> Add check_effective_target_vect_min_max > >>> > >>> 2015-08-12 Tom de Vries > >>> > >>> * lib/target-supports.exp (check_effective_target_vect_min_max): New > >>> proc. > >>> * gcc.dg/vect/trapv-vect-reduc-4.c: Use vect_min_max effective target. > >> > >> Looks good to me, but the new effective-target keyword needs documenting > >> in sourcebuild.texi. > >> > > > > Hmm, in sourcebuild.texi I found: > > ... > > @item vect_no_int_max > > Target does not support a vector max instruction on @code{int}. > > ... > > > > That looks related. [ I also found a patch introducing vect_no_uint_max > > here: https://gcc.gnu.org/ml/gcc-patches/2010-01/msg00152.html. ] > > > > I'm not sure where to take it from here. Should I introduce > > vect_no_int_min, and use that in combination with vect_no_int_max? > > I'd say this is something for the vectorizer maintainers to decide. Richi? I expect the above is already effectively vect_no_int_min as well (which target would support min but not max...?). So after double-checking that you could rename it to vect_no_int_min_max. Richard.