From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-406247-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 4345 invoked by alias); 28 Aug 2015 13:01:43 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 4308 invoked by uid 89); 28 Aug 2015 13:01:42 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx2.suse.de
Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Fri, 28 Aug 2015 13:01:42 +0000
Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])	by mx2.suse.de (Postfix) with ESMTP id CBE69AD8C;	Fri, 28 Aug 2015 13:01:38 +0000 (UTC)
Date: Fri, 28 Aug 2015 13:35:00 -0000
From: Richard Biener <rguenther@suse.de>
To: Alan Lawrence <alan.lawrence@arm.com>
cc: Christophe Lyon <christophe.lyon@linaro.org>,     "martin.jambor@suse.cz" <martin.jambor@suse.cz>,     "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,     Jeff Law <law@redhat.com>
Subject: Re: [PATCH 2/5] completely_scalarize arrays as well as records
In-Reply-To: <55E03315.7080205@arm.com>
Message-ID: <alpine.LSU.2.11.1508281500550.4884@zhemvz.fhfr.qr>
References: <20150825214232.GB12831@virgil.suse.cz> <1440690217-24461-1-git-send-email-alan.lawrence@arm.com> <CAKdteOYL373pKpYB2R=6e+mLr5c=EfermXZshSmzOC-B9St6rA@mail.gmail.com> <alpine.LSU.2.11.1508280946130.4884@zhemvz.fhfr.qr> <CAKdteOY69rzcpqrQm6NnC1XAzgmWi2-KJD3g=wxG=iZpMnu0+A@mail.gmail.com> <55E03315.7080205@arm.com>
User-Agent: Alpine 2.11 (LSU 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2015-08/txt/msg01784.txt.bz2

On Fri, 28 Aug 2015, Alan Lawrence wrote:

> Christophe Lyon wrote:
> > 
> > I asked because I assumed that Alan saw it pass in his configuration.
> 
> 
> Bah. No - I now discover a problem in my C++ testsuite setup that was causing
> a large number of tests to not be executed. I see the problem too now,
> investigating....

Btw, your patch broke Ada:

+===========================GNAT BUG 
DETECTED==============================+
| 6.0.0 20150828 (experimental) (x86_64-pc-linux-gnu) GCC error:           
|
| in completely_scalarize, at tree-sra.c:996                               
|
| Error detected around ../rts/a-coorse.ads:46:24                          
|

    case ARRAY_TYPE:
      {
        tree elemtype = TREE_TYPE (decl_type);
        tree elem_size = TYPE_SIZE (elemtype);
        gcc_assert (elem_size && tree_fits_uhwi_p (elem_size));
        int el_size = tree_to_uhwi (elem_size);
        gcc_assert (el_size);

        tree minidx = TYPE_MIN_VALUE (TYPE_DOMAIN (decl_type));
        tree maxidx = TYPE_MAX_VALUE (TYPE_DOMAIN (decl_type));
        gcc_assert (TREE_CODE (minidx) == INTEGER_CST
                    && TREE_CODE (maxidx) == INTEGER_CST);

obviously you missed VLAs.  min/max value can also be NULL.

Richard.