public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <rguenther@suse.de>
To: "Manuel López-Ibáñez" <lopezibanez@gmail.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH tree-inline v2] do not say "called from here" with UNKNOWN_LOCATION
Date: Tue, 22 Sep 2015 07:49:00 -0000	[thread overview]
Message-ID: <alpine.LSU.2.11.1509220945060.24931@zhemvz.fhfr.qr> (raw)
In-Reply-To: <CAESRpQAJRMf_G36KPrzU6fgn2tz6RkArbMgJ2S+pvo++0Z1y9Q@mail.gmail.com>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1736 bytes --]

On Mon, 21 Sep 2015, Manuel López-Ibáñez wrote:

> In https://sourceware.org/ml/libc-alpha/2014-12/msg00300.html, we give a
> "called from here" note without actually having a location, which looks
> strange. I haven't been able to generate such a testcase. If this happens,
> try to at least point to the current function being called. If that location is
> also unknown, skip the extra note.

Ok.

Thanks,
Richard.

> gcc/ChangeLog:
> 
> 2015-09-21  Manuel López-Ibáñez  <manu@gcc.gnu.org>
> 
>     * tree-inline.c (expand_call_inline): Use inform for extra note.
>     Do not give a note with UNKNOWN_LOCATION.
>     Replace input_location with gimple_location (stmt).
>     Use true instead of TRUE.
> 
> gcc/testsuite/ChangeLog:
> 
> 2015-09-21  Manuel López-Ibáñez  <manu@gcc.gnu.org>
> 
>     * gcc.target/i386/inline_error.c (int bar): Use dg-message for note.
>     * gcc.target/i386/pr57756.c (static __inline int caller): Likewise.
>     * gcc.target/i386/pr59789.c (f1): Likewise.
>     * gcc.target/i386/intrinsics_5.c (__m128i foo): Likewise.
>     * gcc.target/i386/intrinsics_6.c: Likewise.
>     * gcc.dg/winline-5.c (int t): Likewise.
>     * gcc.dg/winline-9.c (t): Likewise.
>     * gcc.dg/always_inline2.c (q): Likewise.
>     * gcc.dg/winline-2.c (inline int t): Likewise.
>     * gcc.dg/winline-6.c: Likewise.
>     * gcc.dg/winline-10.c (void g): Likewise.
>     * gcc.dg/pr49243.c (void parse): Likewise.
>     * gcc.dg/always_inline3.c (q2): Likewise.
>     * gcc.dg/winline-3.c: Likewise.
>     * gcc.dg/winline-7.c (inline void *t): Likewise.
> 

-- 
Richard Biener <rguenther@suse.de>
SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)

      reply	other threads:[~2015-09-22  7:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-21 21:42 Manuel López-Ibáñez
2015-09-22  7:49 ` Richard Biener [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.11.1509220945060.24931@zhemvz.fhfr.qr \
    --to=rguenther@suse.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=lopezibanez@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).