From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-408001-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 102033 invoked by alias); 22 Sep 2015 07:45:17 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 102007 invoked by uid 89); 22 Sep 2015 07:45:16 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx2.suse.de
Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 22 Sep 2015 07:45:15 +0000
Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])	by mx2.suse.de (Postfix) with ESMTP id 5E0D2ABA2;	Tue, 22 Sep 2015 07:45:12 +0000 (UTC)
Date: Tue, 22 Sep 2015 07:49:00 -0000
From: Richard Biener <rguenther@suse.de>
To: =?ISO-8859-15?Q?Manuel_L=F3pez-Ib=E1=F1ez?= <lopezibanez@gmail.com>
cc: Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH tree-inline v2] do not say "called from here" with UNKNOWN_LOCATION
In-Reply-To: <CAESRpQAJRMf_G36KPrzU6fgn2tz6RkArbMgJ2S+pvo++0Z1y9Q@mail.gmail.com>
Message-ID: <alpine.LSU.2.11.1509220945060.24931@zhemvz.fhfr.qr>
References: <CAESRpQAJRMf_G36KPrzU6fgn2tz6RkArbMgJ2S+pvo++0Z1y9Q@mail.gmail.com>
User-Agent: Alpine 2.11 (LSU 23 2013-08-11)
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="-1609908220-538574970-1442907912=:24931"
X-SW-Source: 2015-09/txt/msg01626.txt.bz2

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

---1609908220-538574970-1442907912=:24931
Content-Type: TEXT/PLAIN; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Content-length: 1718

On Mon, 21 Sep 2015, Manuel López-Ibáñez wrote:

> In https://sourceware.org/ml/libc-alpha/2014-12/msg00300.html, we give a
> "called from here" note without actually having a location, which looks
> strange. I haven't been able to generate such a testcase. If this happens,
> try to at least point to the current function being called. If that location is
> also unknown, skip the extra note.

Ok.

Thanks,
Richard.

> gcc/ChangeLog:
> 
> 2015-09-21  Manuel López-Ibáñez  <manu@gcc.gnu.org>
> 
>     * tree-inline.c (expand_call_inline): Use inform for extra note.
>     Do not give a note with UNKNOWN_LOCATION.
>     Replace input_location with gimple_location (stmt).
>     Use true instead of TRUE.
> 
> gcc/testsuite/ChangeLog:
> 
> 2015-09-21  Manuel López-Ibáñez  <manu@gcc.gnu.org>
> 
>     * gcc.target/i386/inline_error.c (int bar): Use dg-message for note.
>     * gcc.target/i386/pr57756.c (static __inline int caller): Likewise.
>     * gcc.target/i386/pr59789.c (f1): Likewise.
>     * gcc.target/i386/intrinsics_5.c (__m128i foo): Likewise.
>     * gcc.target/i386/intrinsics_6.c: Likewise.
>     * gcc.dg/winline-5.c (int t): Likewise.
>     * gcc.dg/winline-9.c (t): Likewise.
>     * gcc.dg/always_inline2.c (q): Likewise.
>     * gcc.dg/winline-2.c (inline int t): Likewise.
>     * gcc.dg/winline-6.c: Likewise.
>     * gcc.dg/winline-10.c (void g): Likewise.
>     * gcc.dg/pr49243.c (void parse): Likewise.
>     * gcc.dg/always_inline3.c (q2): Likewise.
>     * gcc.dg/winline-3.c: Likewise.
>     * gcc.dg/winline-7.c (inline void *t): Likewise.
> 

-- 
Richard Biener <rguenther@suse.de>
SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)
---1609908220-538574970-1442907912=:24931--