From: Richard Biener <rguenther@suse.de>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Adjust some patterns wrt :c
Date: Tue, 27 Oct 2015 12:08:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.11.1510271258590.28064@zhemvz.fhfr.qr> (raw)
In-Reply-To: <alpine.DEB.2.20.1510261730490.15133@laptop-mg.saclay.inria.fr>
On Mon, 26 Oct 2015, Marc Glisse wrote:
> On Mon, 26 Oct 2015, Richard Biener wrote:
>
> > @@ -435,7 +435,7 @@ (define_operator_list RINT BUILT_IN_RINT
> >
> > /* Fold (A & ~B) - (A & B) into (A ^ B) - B. */
> > (simplify
> > - (minus (bit_and:cs @0 (bit_not @1)) (bit_and:s @0 @1))
> > + (minus (bit_and:cs @0 (bit_not @1)) (bit_and:cs @0 @1))
> > (minus (bit_xor @0 @1) @1))
>
> Sorry, I should have listed them all, but the same applies to
> /* Fold (A & B) - (A & ~B) into B - (A ^ B). */
> a few lines below.
Heh. I wonder if we can teach genmatch to auto-annotate commutative
operands (detecting the cases where it doesn't get us anything but
redundant patterns). Or implement a warning that catches them at
least.
Anyway, fixed in my local tree, will go out with my next match.pd
modification.
Richard.
prev parent reply other threads:[~2015-10-27 12:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 13:29 Richard Biener
2015-10-26 16:51 ` Marc Glisse
2015-10-27 12:08 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.1510271258590.28064@zhemvz.fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).