From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18758 invoked by alias); 23 Nov 2015 09:46:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18709 invoked by uid 89); 23 Nov 2015 09:46:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Mon, 23 Nov 2015 09:46:09 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id D3162ACE0; Mon, 23 Nov 2015 09:45:02 +0000 (UTC) Date: Mon, 23 Nov 2015 09:54:00 -0000 From: Richard Biener To: Jeff Law cc: Senthil Kumar Selvaraj , gcc-patches@gcc.gnu.org Subject: Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode In-Reply-To: <564F599D.2010109@redhat.com> Message-ID: References: <20151114071148.GA16647@jaguar.atmel.com> <20151114084928.GA749@jaguar.atmel.com> <595F0CF8-27C1-4A63-8339-F70CB5E76CAB@suse.de> <20151114181044.GA1297@jaguar.atmel.com> <20151117195241.GA5579@jaguar.atmel.com> <20151119062014.GA2345@jaguar.corp.atmel.com> <564E077D.4020908@redhat.com> <20151120170410.GA698@jaguar.atmel.com> <564F599D.2010109@redhat.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2015-11/txt/msg02664.txt.bz2 On Fri, 20 Nov 2015, Jeff Law wrote: > On 11/20/2015 10:04 AM, Senthil Kumar Selvaraj wrote: > > On Thu, Nov 19, 2015 at 10:31:41AM -0700, Jeff Law wrote: > > > On 11/18/2015 11:20 PM, Senthil Kumar Selvaraj wrote: > > > > On Wed, Nov 18, 2015 at 09:36:21AM +0100, Richard Biener wrote: > > > > > > > > > > Otherwise ok. > > > > > > > > See modified patch below. If you think vrp98.c is unnecessary, feel free > > > > to dump it :). > > > > > > > > If ok, could you commit it for me please? I don't have commit access. > > > > > > > > Regards > > > > Senthil > > > > > > > > gcc/ChangeLog > > > > 2015-11-19 Senthil Kumar Selvaraj > > > > > > > > * tree.h (desired_pro_or_demotion_p): New function. > > > > * tree-vrp.c (simplify_cond_using_ranges): Call it. > > > > > > > > gcc/testsuite/ChangeLog > > > > 2015-11-19 Senthil Kumar Selvaraj > > > > > > > > * gcc.dg/tree-ssa/vrp98.c: New testcase. > > > > * gcc.target/avr/uint8-single-reg.c: New testcase. > > > I went ahead and committed this as-is. > > > > > > I do think the vrp98 testcase is useful as it verifies that VRP is doing > > > what we want in a target independent way. It's a good complement to the > > > AVR > > > specific testcase. > > > > I see the same problem on gcc-5-branch as well. Would it be ok to > > backport the fix to that branch as well? > That's a call for the release managers. I typically don't backport anything > expect ICE or incorrect code generation fixes as I tend to be very > conservative on what goes onto a release branch. > > Jakub, Richi or Joseph would need to ack into a release branch. As this is fixes a regression it qualifies in principle. But as it is an optimization regression only I'd prefer to wait a bit to look for fallout. Richard. > jeff > > -- Richard Biener SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)