From: Richard Biener <rguenther@suse.de>
To: Jiong Wang <jiong.wang@foss.arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch] PR68137, drop constant overflow flag in adjust_range_with_scev when possible
Date: Mon, 23 Nov 2015 12:11:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.11.1511231259460.4884@t29.fhfr.qr> (raw)
In-Reply-To: <5652F337.8090800@foss.arm.com>
On Mon, 23 Nov 2015, Jiong Wang wrote:
> As reported by pr68137 and pr68326, r230150 caused new issues.
>
> Those ICEs are caused by adjust_range_with_scev getting range with
> overflowed constants min or max. So given there are too many places to
> generate OVF, we do a check in adjust_range_with_scev, to drop OVF flag
> when it's uncessary. This should fix the OVF side-effect caused by
> r230150.
>
> A simple regression testcase is included in this patch.
>
> bootstrap OK on x86-64 and aarch64, regression ok on both.
>
> For more background, please see discussion at
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68317
>
> OK for trunk?
Ok.
Thanks,
Richard.
> 2015-11-23 Richard Biener <rguenth@gcc.gnu.com>
> Jiong Wang <jiong.wang@arm.com>
>
> gcc/
> PR tree-optimization/68137
> PR tree-optimization/68326
> * tree-vrp.c (adjust_range_with_scev): Call drop_tree_overflow if the
> final min and max are not infinity.
>
> gcc/testsuite/
> * gcc.dg/pr68139.c: New testcase.
prev parent reply other threads:[~2015-11-23 12:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 11:08 Jiong Wang
2015-11-23 12:11 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.1511231259460.4884@t29.fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jiong.wang@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).