public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <rguenther@suse.de>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: Eric Botcazou <ebotcazou@adacore.com>, gcc-patches@gcc.gnu.org
Subject: Re: -fstrict-aliasing fixes 5/6: make type system independent of flag_strict_aliasing
Date: Wed, 09 Dec 2015 09:05:00 -0000	[thread overview]
Message-ID: <alpine.LSU.2.11.1512090959140.4884@t29.fhfr.qr> (raw)
In-Reply-To: <20151209072955.GA8345@kam.mff.cuni.cz>

On Wed, 9 Dec 2015, Jan Hubicka wrote:

> Hi
> this patch implements the trik for punting if we get too many nested pointers.
> This fixes the ada tstcases. Curiously enough I would like to replace safe_push
> by quick_push but doing so I get weird error about freeing non-heap object
> in the auto_vec desructor...

That's odd but a sign of you doing sth wrong ;)  Like somehow
clobbering m_using_auto_storage of the vec.

But of course if you use a maximum length of 8 there
is no need to use a vec<>, just use a fixed bool[8] array
(or an integer mask).

> Bootstraping/regtesting x86_64-linux. Ok if it passes?

Ok.

Thanks,
Richard.

> Honza
> 
> 	* alias.c (get_alias_set): Punt after getting 8 nested pointers.
> 
> Index: alias.c
> ===================================================================
> --- alias.c	(revision 231439)
> +++ alias.c	(working copy)
> @@ -990,6 +990,14 @@ get_alias_set (tree t)
>  	   || TREE_CODE (p) == VECTOR_TYPE;
>  	   p = TREE_TYPE (p))
>  	{
> +	  /* Ada supports recusive pointers.  Instead of doing recrusion check
> +	     just give up once the preallocated space of 8 elements is up.
> +	     In this case just punt to void * alias set.  */
> +	  if (reference.length () == 8)
> +	    {
> +	      p = ptr_type_node;
> +	      break;
> +	    }
>  	  if (TREE_CODE (p) == REFERENCE_TYPE)
>  	    /* In LTO we want languages that use references to be compatible
>   	       with languages that use pointers.  */

      parent reply	other threads:[~2015-12-09  9:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02  8:07 Jan Hubicka
2015-12-02  9:14 ` Richard Biener
2015-12-02 17:12   ` Jan Hubicka
2015-12-06 17:25 ` Eric Botcazou
2015-12-07 18:54   ` Jan Hubicka
2015-12-07 19:49     ` Jan Hubicka
2015-12-08 12:06       ` Eric Botcazou
2015-12-08 12:19         ` Richard Biener
2015-12-08 17:09           ` Eric Botcazou
2015-12-08 19:27             ` Jan Hubicka
2015-12-08 19:49               ` Eric Botcazou
2015-12-09  7:30   ` Jan Hubicka
2015-12-09  8:16     ` Arnaud Charlet
2015-12-09  9:11       ` Richard Biener
2015-12-09 16:58         ` Jan Hubicka
2015-12-09  9:05     ` Richard Biener [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.11.1512090959140.4884@t29.fhfr.qr \
    --to=rguenther@suse.de \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).