From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-417561-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 129944 invoked by alias); 17 Dec 2015 11:41:56 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 129928 invoked by uid 89); 17 Dec 2015 11:41:55 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=symmetry, cc-ing, Belevantsev, sk:bb_top_
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mx2.suse.de
Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 17 Dec 2015 11:41:55 +0000
Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])	by mx2.suse.de (Postfix) with ESMTP id 18A85ABA3;	Thu, 17 Dec 2015 11:41:51 +0000 (UTC)
Date: Thu, 17 Dec 2015 11:41:00 -0000
From: Richard Biener <rguenther@suse.de>
To: Yury Gribov <y.gribov@samsung.com>
cc: GCC Patches <gcc-patches@gcc.gnu.org>, Andrey Belevantsev <abel@ispras.ru>,     Andrew MacLeod <amacleod@redhat.com>, Andrew Pinski <pinskia@gmail.com>,     Diego Novillo <dnovillo@google.com>, Geoff Keating <geoffk@geoffk.org>,     Jakub Jelinek <jakub@redhat.com>, Jason Merrill <jason@redhat.com>,     Steven Bosscher <steven@gcc.gnu.org>
Subject: Re: [PATCH 1/5] Fix asymmetric comparison functions
In-Reply-To: <56727936.4030605@samsung.com>
Message-ID: <alpine.LSU.2.11.1512171239260.3571@t29.fhfr.qr>
References: <5672787D.6040105@samsung.com> <56727936.4030605@samsung.com>
User-Agent: Alpine 2.11 (LSU 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2015-12/txt/msg01737.txt.bz2

On Thu, 17 Dec 2015, Yury Gribov wrote:

> Some obvious symmetry fixes.
> 
> Cc-ing
> * Andrey (Belevantsev) for bb_top_order_comparator
> * Andrew (MacLeod) for compare_case_labels
> * Andrew (Pinski) for resort_field_decl_cmp
> * Diego for pair_cmp
> * Geoff for resort_method_name_cmp
> * Jakub for compare_case_labels
> * Jason for method_name_cmp
> * Richard for insert_phi_nodes_compare_var_infos, compare_case_labels
> * Steven for cmp_v_in_regset_pool

So for compare_case_labels we only ever have one label with
!CASE_LOW - which means you only run into the case that needs
!CASE_LOW && !CASE_LOW if comparing an element with itself, correct?

In this case (missing "same element" handling rather than symmetry
fixing) I'd prefer a

 if (case1 == case2)
   return 0;

So just to confirm - do the patches also contain same element
compare fixings?

Richard.