Re: [PATCH][RFC] Introduce BIT_FIELD_INSERT

[Richard Biener <rguenther@suse.de>]

On Fri, 20 May 2016, Jakub Jelinek wrote:

> On Fri, May 20, 2016 at 10:59:18AM +0200, Richard Biener wrote:
> > Sounds good.  I will commit later with your wording.
> 
> Unfortunately, the new testcase fails e.g. on i?86-*-* or on powerpc*.
> On i?86-*-* (without -msse) I actually see 2 different issues, one is
> extra -Wpsabi warnings, and another is the dump scan, the optimization isn't
> used there at all if we don't have SSE HW.
> Surprisingly, on powerpc* the only problem is the extra warnings about ABI
> compatibility, but the scan matches, even if there is no vector support.
> Similarly on s390* too (and there are no warnings even).

I suppose they still have vector modes enabled.

> So, dunno if we should limit the scan-tree-dump-times only to a few selected
> arches (e.g. those where we add dg-additional-options for, plus some where
> it is known to work without additional options, like perhaps aarch64*-*-*,
> maybe spu*-*-*, what else?).

I'd say ppc and aarch64 are fine.  Thanks for noticing.

Richard.

> 2016-05-20  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR tree-optimization/29756
> 	gcc.dg/tree-ssa/vector-6.c: Add -Wno-psabi -w to dg-options.
> 	Add -msse2 for x86 and -maltivec for powerpc.
> 
> --- gcc/testsuite/gcc.dg/tree-ssa/vector-6.c.jj	2016-05-20 12:44:33.000000000 +0200
> +++ gcc/testsuite/gcc.dg/tree-ssa/vector-6.c	2016-05-20 13:17:08.730168547 +0200
> @@ -1,5 +1,7 @@
>  /* { dg-do compile } */
> -/* { dg-options "-O -fdump-tree-ccp1" } */
> +/* { dg-options "-O -fdump-tree-ccp1 -Wno-psabi -w" } */
> +/* { dg-additional-options "-msse2" { target i?86-*-* x86_64-*-* } } */
> +/* { dg-additional-options "-maltivec" { target powerpc_altivec_ok } } */
>  
>  typedef int v4si __attribute__((vector_size (4 * sizeof (int))));
>  
> 
> 
> 	Jakub