From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21660 invoked by alias); 1 Jun 2016 13:07:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21651 invoked by uid 89); 1 Jun 2016 13:07:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*Ad:U*jh, Hx-languages-length:1115, IPA, states X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 01 Jun 2016 13:07:12 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0A4ADAB43; Wed, 1 Jun 2016 13:07:09 +0000 (UTC) Date: Wed, 01 Jun 2016 13:07:00 -0000 From: Richard Biener To: Prathamesh Kulkarni cc: gcc Patches , Jan Hubicka Subject: Re: move increase_alignment from simple to regular ipa pass In-Reply-To: Message-ID: References: User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2016-06/txt/msg00039.txt.bz2 On Wed, 1 Jun 2016, Prathamesh Kulkarni wrote: > Hi Richard, > This patch tries to move increase_alignment pass from small to regular ipa pass. > Does the patch look correct ? > Since we are only increasing alignment of varpool nodes, I am not sure > if any ipa > read/write hooks were necessary and passed NULL for them. > Cross-tested on arm*-*-*, aarch64*-*-*, > Bootstrap+test on aarch64-linux-gnu in progress. I think the patch looks sensible apart from the fact that both flag_section_anchors and flag_tree_vectorize can have different states for each function. This would mean the pass should get its own non-Optimization flag initialized by targets where section anchors are usually used and it means you'd want to walk IPA refs to see whether variables are used in a function with both section anchors and vectorization enabled. Honza may have further comments. Thanks, Richard. > Thanks, > Prathamesh > -- Richard Biener SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)