From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-429378-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 57403 invoked by alias); 9 Jun 2016 08:45:04 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 57355 invoked by uid 89); 9 Jun 2016 08:45:02 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=BAYES_00,KAM_ASCII_DIVIDERS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1842
X-HELO: mx2.suse.de
Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 09 Jun 2016 08:44:52 +0000
Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])	by mx2.suse.de (Postfix) with ESMTP id 18A9BACEC	for <gcc-patches@gcc.gnu.org>; Thu,  9 Jun 2016 08:44:49 +0000 (UTC)
Date: Thu, 09 Jun 2016 08:45:00 -0000
From: Richard Biener <rguenther@suse.de>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH] Fix PR71462
Message-ID: <alpine.LSU.2.11.1606091043520.1493@t29.fhfr.qr>
User-Agent: Alpine 2.11 (LSU 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2016-06/txt/msg00651.txt.bz2


I am testing the following patch to robustify into-loop-closed-SSA
rewrite against removed blocks in the changed_bbs bitmap.

Bootstrap and regtest running on x86_64-unknown-linux-gnu.

Richard.

2016-06-09  Richard Biener  <rguenther@suse.de>

	PR tree-optimization/71462
	* tree-ssa-loop-manip.c (find_uses_to_rename): Guard against
	removed blocks.

	* gcc.dg/torture/pr71462.c: New testcase.

Index: gcc/tree-ssa-loop-manip.c
===================================================================
*** gcc/tree-ssa-loop-manip.c	(revision 237248)
--- gcc/tree-ssa-loop-manip.c	(working copy)
*************** find_uses_to_rename (bitmap changed_bbs,
*** 472,479 ****
  
    if (changed_bbs)
      EXECUTE_IF_SET_IN_BITMAP (changed_bbs, 0, index, bi)
!       find_uses_to_rename_bb (BASIC_BLOCK_FOR_FN (cfun, index), use_blocks,
! 			      need_phis, use_flags);
    else
      FOR_EACH_BB_FN (bb, cfun)
        find_uses_to_rename_bb (bb, use_blocks, need_phis, use_flags);
--- 472,482 ----
  
    if (changed_bbs)
      EXECUTE_IF_SET_IN_BITMAP (changed_bbs, 0, index, bi)
!       {
! 	bb = BASIC_BLOCK_FOR_FN (cfun, index);
! 	if (bb)
! 	  find_uses_to_rename_bb (bb, use_blocks, need_phis, use_flags);
!       }
    else
      FOR_EACH_BB_FN (bb, cfun)
        find_uses_to_rename_bb (bb, use_blocks, need_phis, use_flags);
Index: gcc/testsuite/gcc.dg/torture/pr71462.c
===================================================================
*** gcc/testsuite/gcc.dg/torture/pr71462.c	(revision 0)
--- gcc/testsuite/gcc.dg/torture/pr71462.c	(working copy)
***************
*** 0 ****
--- 1,28 ----
+ /* { dg-do compile } */
+ 
+ short a;
+ long b;
+ void fn1()
+ {
+   int c = a = 1;
+   for (; a; a++)
+     {
+       for (; 9 <= 8;)
+ 	for (;;) {
+ 	    a = 20;
+ 	    for (; a <= 35; a++)
+ 	      ;
+ line:;
+ 	}
+       if ((c += 264487869) == 9)
+ 	{
+ 	  unsigned *d = 0;
+ 	  for (; b;)
+ 	    d = (unsigned *)&c;
+ 	  if (d)
+ 	    for (;;)
+ 	      ;
+ 	}
+     }
+   goto line;
+ }