* [PATCH] Fix (parts of) PR68273
@ 2016-08-05 11:18 Richard Biener
2016-08-09 8:51 ` Matthew Fortune
0 siblings, 1 reply; 2+ messages in thread
From: Richard Biener @ 2016-08-05 11:18 UTC (permalink / raw)
To: gcc-patches
The following patch avoids overaligned types created from IPA parameter
replacement. It is said to help mipsel which still suffers from the
backend-looks-at-type-alignment-for-parameter-passing-ABI bug.
Bootstrap and regtest pending on x86_64-unknown-linux-gnu.
mips testing appreciated.
Richard.
2016-08-05 Richard Biener <rguenther@suse.de>
PR ipa/68273
* ipa-prop.c (ipa_modify_formal_parameters): Build
parameter types with natural alignment also for the
over-aligned case.
Index: gcc/ipa-prop.c
===================================================================
--- gcc/ipa-prop.c (revision 239164)
+++ gcc/ipa-prop.c (working copy)
@@ -3910,7 +3909,7 @@ ipa_modify_formal_parameters (tree fndec
if (is_gimple_reg_type (ptype))
{
unsigned malign = GET_MODE_ALIGNMENT (TYPE_MODE (ptype));
- if (TYPE_ALIGN (ptype) < malign)
+ if (TYPE_ALIGN (ptype) != malign)
ptype = build_aligned_type (ptype, malign);
}
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] Fix (parts of) PR68273
2016-08-05 11:18 [PATCH] Fix (parts of) PR68273 Richard Biener
@ 2016-08-09 8:51 ` Matthew Fortune
0 siblings, 0 replies; 2+ messages in thread
From: Matthew Fortune @ 2016-08-09 8:51 UTC (permalink / raw)
To: Richard Biener, gcc-patches
Richard Biener <rguenther@suse.de> writes:
> The following patch avoids overaligned types created from IPA parameter
> replacement. It is said to help mipsel which still suffers from the
> backend-looks-at-type-alignment-for-parameter-passing-ABI bug.
>
> Bootstrap and regtest pending on x86_64-unknown-linux-gnu.
>
> mips testing appreciated.
Thanks Richard.
Regtest on mips-linux-gnu for mips32r2 is fine. My bootstrap failed for
unrelated reasons.
Matthew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-09 8:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-05 11:18 [PATCH] Fix (parts of) PR68273 Richard Biener
2016-08-09 8:51 ` Matthew Fortune
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).