Re: [PATCH] Fix PR69047

[Richard Biener <rguenther@suse.de>]

On Mon, 29 Aug 2016, Andreas Schwab wrote:

> On Aug 26 2016, Richard Biener <rguenther@suse.de> wrote:
> 
> > Index: gcc/testsuite/gcc.dg/pr69047.c
> > ===================================================================
> > --- gcc/testsuite/gcc.dg/pr69047.c	(revision 0)
> > +++ gcc/testsuite/gcc.dg/pr69047.c	(working copy)
> > @@ -0,0 +1,18 @@
> > +/* { dg-do compile } */
> > +/* { dg-options "-O -fdump-tree-cddce1" } */
> > +
> > +__UINT8_TYPE__
> > +f(__UINT16_TYPE__ b)
> > +{
> > +  __UINT8_TYPE__ a;
> > +#if __BYTE_ORDER == __LITTLE_ENDIAN
> > +  __builtin_memcpy(&a, &b, sizeof a);
> > +#elif __BYTE_ORDER == __BIG_ENDIAN
> > +  __builtin_memcpy(&a, (char *)&b + sizeof a, sizeof a);
> > +#else
> > +  a = b;
> > +#endif
> > +  return a;
> > +}
> > +
> > +/* { dg-final { scan-tree-dump "_\[0-9\]+ = \\(\[^)\]+\\) b" "cddce1" } } */
> >
> 
> On m68k:
> 
> FAIL: gcc.dg/pr69047.c scan-tree-dump cddce1 "_[0-9]+ = \\([^)]+\\) b"
> 
> $ cat pr69047.c.037t.cddce1 
> 
> ;; Function f (f, funcdef_no=0, decl_uid=1432, cgraph_uid=0, symbol_order=0)
> 
> f (short unsigned int b)
> {
>   unsigned char a;
>   unsigned char _2;
> 
>   <bb 2>:
>   _2 = BIT_FIELD_REF <b_6(D), 8, 0>;
>   return _2;
> 
> }
> 
> 
> Andreas.

Ah, forgot to re-write to use GCC internal macros.

Tested on m68k, applied.

Richard.

2016-08-30  Richard Biener  <rguenther@suse.de>

	PR tree-optimization/69047
	* gcc.dg/pr69047.c: Fix byte-order check.

Index: gcc/testsuite/gcc.dg/pr69047.c
===================================================================
--- gcc/testsuite/gcc.dg/pr69047.c	(revision 239856)
+++ gcc/testsuite/gcc.dg/pr69047.c	(working copy)
@@ -5,9 +5,9 @@ __UINT8_TYPE__
 f(__UINT16_TYPE__ b)
 {
   __UINT8_TYPE__ a;
-#if __BYTE_ORDER == __LITTLE_ENDIAN
+#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
   __builtin_memcpy(&a, &b, sizeof a);
-#elif __BYTE_ORDER == __BIG_ENDIAN
+#elif __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
   __builtin_memcpy(&a, (char *)&b + sizeof a, sizeof a);
 #else
   a = b;