From: Richard Biener <rguenther@suse.de>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH] Fix PR77826
Date: Tue, 04 Oct 2016 10:34:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.11.1610041232450.26629@t29.fhfr.qr> (raw)
The following will fix PR77826, the issue that in match.pd matching
up two things uses operand_equal_p which is too lax about the type
of the toplevel entity (at least for integer constants).
Bootstrap / regtest pending on x86_64-unknown-linux-gnu.
Richard.
2016-10-04 Richard Biener <rguenther@suse.de>
PR middle-end/77826
* genmatch.c (dt_operand::gen_match_op): Amend operand_equal_p
with types_match to handle type mismatched constants properly.
* gcc.dg/torture/pr77826.c: New testcase.
Index: gcc/genmatch.c
===================================================================
--- gcc/genmatch.c (revision 240739)
+++ gcc/genmatch.c (working copy)
@@ -2593,8 +2601,10 @@ dt_operand::gen_match_op (FILE *f, int i
{
char match_opname[20];
match_dop->get_name (match_opname);
- fprintf_indent (f, indent, "if (%s == %s || operand_equal_p (%s, %s, 0))\n",
- opname, match_opname, opname, match_opname);
+ fprintf_indent (f, indent, "if (%s == %s || (operand_equal_p (%s, %s, 0) "
+ "&& types_match (%s, %s)))\n",
+ opname, match_opname, opname, match_opname,
+ opname, match_opname);
fprintf_indent (f, indent + 2, "{\n");
return 1;
}
Index: gcc/testsuite/gcc.dg/torture/pr77826.c
===================================================================
--- gcc/testsuite/gcc.dg/torture/pr77826.c (revision 0)
+++ gcc/testsuite/gcc.dg/torture/pr77826.c (working copy)
@@ -0,0 +1,12 @@
+/* { dg-do compile } */
+
+void
+fi(unsigned long int *v0, unsigned int ow, int q2)
+{
+ if (ow + q2 != 0)
+ if (q2 == 1)
+ {
+ *v0 |= q2;
+ q2 ^= *v0;
+ }
+}
next reply other threads:[~2016-10-04 10:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 10:34 Richard Biener [this message]
2016-10-05 11:38 ` Richard Biener
2016-10-06 18:44 ` Marc Glisse
2016-10-07 7:36 ` Richard Biener
2016-10-10 8:47 ` Marc Glisse
2016-10-11 9:09 ` Richard Biener
2016-10-11 20:35 ` Marc Glisse
2016-10-12 11:34 ` Richard Biener
2016-10-12 12:49 ` Marc Glisse
2016-10-12 13:25 ` Richard Biener
2016-10-13 8:29 ` Richard Biener
2016-10-15 21:50 ` Marc Glisse
2016-10-17 7:59 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.1610041232450.26629@t29.fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).