public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [RFC][IPA-VRP] ADDR_EXPR and nonnull
@ 2016-10-19  2:12 kugan
  2016-10-19  8:24 ` Richard Biener
  0 siblings, 1 reply; 14+ messages in thread
From: kugan @ 2016-10-19  2:12 UTC (permalink / raw)
  To: Richard Biener, Jan Hubicka, gcc-patches

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

Hi,

While computing jump function value range for pointer, I am wondering if 
we can assume that any tree with ADDR_EXPR will be nonnull.

That is, in cases like:

int arr[10];
foo (&arr[1]);

OR

struct st
{
   int a;
   int b;
};
struct st s2;
foo (&s2.a);

Attached patch tries to do this. I am not sure if this can be wrong. Any 
thoughts?

Attached patch bootstraps and regression testing didn't introduce any 
new regressions.

Thanks,
Kugan


gcc/ChangeLog:

2016-10-19  Kugan Vivekanandarajah  <kuganv@linaro.org>

	* ipa-prop.c (ipa_compute_jump_functions_for_edge): Set
	value range to nonull for ADDR_EXPR.

gcc/testsuite/ChangeLog:

2016-10-19  Kugan Vivekanandarajah  <kuganv@linaro.org>

	* gcc.dg/ipa/vrp5.c: New test.
	* gcc.dg/ipa/vrp6.c: New test.

[-- Attachment #2: p.txt --]
[-- Type: text/plain, Size: 1919 bytes --]

diff --git a/gcc/ipa-prop.c b/gcc/ipa-prop.c
index 353b638..b795d30 100644
--- a/gcc/ipa-prop.c
+++ b/gcc/ipa-prop.c
@@ -1670,9 +1670,10 @@ ipa_compute_jump_functions_for_edge (struct ipa_func_body_info *fbi,
 
       if (POINTER_TYPE_P (TREE_TYPE (arg)))
 	{
-	  if (TREE_CODE (arg) == SSA_NAME
-	      && param_type
-	      && get_ptr_nonnull (arg))
+	  if ((TREE_CODE (arg) == SSA_NAME
+	       && param_type
+	       && get_ptr_nonnull (arg))
+	      || (TREE_CODE (arg) == ADDR_EXPR))
 	    {
 	      jfunc->vr_known = true;
 	      jfunc->m_vr.type = VR_ANTI_RANGE;
diff --git a/gcc/testsuite/gcc.dg/ipa/vrp5.c b/gcc/testsuite/gcc.dg/ipa/vrp5.c
index e69de29..8e43a65 100644
--- a/gcc/testsuite/gcc.dg/ipa/vrp5.c
+++ b/gcc/testsuite/gcc.dg/ipa/vrp5.c
@@ -0,0 +1,28 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-ipa-cp-details -fdump-tree-vrp1" } */
+
+static __attribute__((noinline, noclone))
+int foo (int *p)
+{
+  if (!p)
+    return 0;
+  *p = 1;
+}
+
+struct st
+{
+  int a;
+  int b;
+};
+
+int bar (struct st *s)
+{
+int arr[10];
+  if (!s)
+    return 0;
+  foo (&s->a);
+  foo (&arr[1]);
+}
+
+/* { dg-final { scan-ipa-dump "Setting nonnull for 0" "cp" } } */
+/* { dg-final { scan-tree-dump-times "if" 1 "vrp1" } } */
diff --git a/gcc/testsuite/gcc.dg/ipa/vrp6.c b/gcc/testsuite/gcc.dg/ipa/vrp6.c
index e69de29..f837758 100644
--- a/gcc/testsuite/gcc.dg/ipa/vrp6.c
+++ b/gcc/testsuite/gcc.dg/ipa/vrp6.c
@@ -0,0 +1,28 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-ipa-cp-details -fdump-tree-vrp1" } */
+
+static __attribute__((noinline, noclone))
+int foo (int *p)
+{
+  if (!p)
+    return 0;
+  *p = 1;
+}
+
+struct st
+{
+  int a;
+  int b;
+};
+
+int bar (struct st *s)
+{
+struct st s2;
+  if (!s)
+    return 0;
+  foo (&s->a);
+  foo (&s2.a);
+}
+
+/* { dg-final { scan-ipa-dump "Setting nonnull for 0" "cp" } } */
+/* { dg-final { scan-tree-dump-times "if" 1 "vrp1" } } */

^ permalink raw reply	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2016-10-21  8:08 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-19  2:12 [RFC][IPA-VRP] ADDR_EXPR and nonnull kugan
2016-10-19  8:24 ` Richard Biener
2016-10-19  8:48   ` kugan
2016-10-19  9:26     ` Richard Biener
2016-10-19 14:26       ` Jan Hubicka
2016-10-20  3:13         ` kugan
2016-10-20  7:42           ` Richard Biener
2016-10-20 11:56             ` kugan
2016-10-20 12:09               ` Richard Biener
2016-10-20 12:15               ` Jan Hubicka
2016-10-21  3:39                 ` kugan
2016-10-21  7:16                   ` Richard Biener
2016-10-21  7:38                     ` kugan
2016-10-21  8:08                       ` Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).