public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
	gcc-patches@gcc.gnu.org,
	    Ed Smith-Rowland <3dw4rd@verizon.net>
Subject: Re: [wwwdocs] Document __has_attribute in /gcc-5/changes.html
Date: Tue, 07 Apr 2015 08:38:00 -0000	[thread overview]
Message-ID: <alpine.LSU.2.20.1504071033320.9357@tuna.site> (raw)
In-Reply-To: <20150311184201.GC4981@redhat.com>

Hi Jonathan,

On Wed, 11 Mar 2015, Jonathan Wakely wrote:
> Yep, revised patch attached.

reading this update, there are some changes I'd like to suggest.

Some (or all ;-) may be disagreeable; they all stem from me
trying to understand this update.

One question: where it refers to __has_attribute returning a
date in some cases, would it make sense to provide an example
or show the format?

By the way, gcc/doc/ does not seem to contain any documentation
of this macro?  Shouldn't that be described there?

Gerald


Index: gcc-5/changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-5/changes.html,v
retrieving revision 1.94
diff -u -r1.94 changes.html
--- gcc-5/changes.html	6 Apr 2015 12:56:40 -0000	1.94
+++ gcc-5/changes.html	7 Apr 2015 08:33:27 -0000
@@ -253,7 +253,7 @@
         of the standard directive <code>#include</code>
         and the extension <code>#include_next</code> respectively.
     </li>
-    <li>A new built-in function-like macro to detect the existence of an
+    <li>A new built-in function-like macro to determine the existence of an
 	attribute, <code>__has_attribute</code>, has been added.
 	The equivalent built-in macro <code>__has_cpp_attribute</code> was
 	added to C++ to support
@@ -270,11 +270,11 @@
 #endif
 foo(int x);
 </pre></blockquote>
-	If an attribute exists a nonzero constant integer is returned.
+	If an attribute exists, a nonzero constant integer is returned.
 	For standardized C++ attributes a date is returned, otherwise the
 	constant returned is 1.
-	The has_attribute macros will add underscores to an attribute name
-	if necessary to resolve the name.
+	The <code>has_attribute</code> macro will add underscores to an
+	attribute name if necessary to resolve the name.
 	For C++11 and onwards the attribute may be scoped.
     </li>
     <li>A new set of built-in functions for arithmetics with overflow checking

  reply	other threads:[~2015-04-07  8:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 18:09 Jonathan Wakely
2015-03-11 18:16 ` Jakub Jelinek
2015-03-11 18:42   ` Jonathan Wakely
2015-04-07  8:38     ` Gerald Pfeifer [this message]
2015-04-07  8:41       ` Jakub Jelinek
2015-04-07  9:10       ` Jonathan Wakely
2015-04-09 23:28         ` Gerald Pfeifer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.20.1504071033320.9357@tuna.site \
    --to=gerald@pfeifer.com \
    --cc=3dw4rd@verizon.net \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=jwakely@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).