From: Gerald Pfeifer <gerald@pfeifer.com>
To: Jakub Jelinek <jakub@redhat.com>, Jonathan Wakely <jwakely@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Ed Smith-Rowland <3dw4rd@verizon.net>
Subject: Re: [wwwdocs] Document __has_attribute in /gcc-5/changes.html
Date: Thu, 09 Apr 2015 23:28:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.20.1504100126530.9357@tuna.site> (raw)
In-Reply-To: <20150407090952.GZ9755@redhat.com>
On Tue, 7 Apr 2015, Jakub Jelinek wrote:
> This change looks problematic to me, as there is no has_attribute macro,
> the "has_attribute macros" phrase was meant to stand for
> "<code>__has_attribute</code> and <code>__has_cpp_attribute</code> macros".
> For <code> I assume we want exact spelling.
Yes, that's a very good point.
On Tue, 7 Apr 2015, Jonathan Wakely wrote:
> The referenced SD-6 document shows the values and format:
> http://isocpp.org/std/standing-documents/sd-6-sg10-feature-test-recommendations
>
> I would expect that most people using the macros are going to be
> referring to that document anyway.
This is a fair point as well.
Thanks for your feedback, Jakub and Jonathan. This is what I
just committed.
Gerald
Index: changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-5/changes.html,v
retrieving revision 1.99
diff -u -r1.99 changes.html
--- changes.html 9 Apr 2015 15:05:01 -0000 1.99
+++ changes.html 9 Apr 2015 23:26:37 -0000
@@ -262,7 +262,7 @@
of the standard directive <code>#include</code>
and the extension <code>#include_next</code> respectively.
</li>
- <li>A new built-in function-like macro to detect the existence of an
+ <li>A new built-in function-like macro to determine the existence of an
attribute, <code>__has_attribute</code>, has been added.
The equivalent built-in macro <code>__has_cpp_attribute</code> was
added to C++ to support
@@ -279,11 +279,12 @@
#endif
foo(int x);
</pre></blockquote>
- If an attribute exists a nonzero constant integer is returned.
+ If an attribute exists, a nonzero constant integer is returned.
For standardized C++ attributes a date is returned, otherwise the
constant returned is 1.
- The has_attribute macros will add underscores to an attribute name
- if necessary to resolve the name.
+ Both <code>__has_attribute</code> and
+ <code>__has_cpp_attribute</code> will add underscores to an
+ attribute name if necessary to resolve the name.
For C++11 and onwards the attribute may be scoped.
</li>
<li>A new set of built-in functions for arithmetics with overflow checking
prev parent reply other threads:[~2015-04-09 23:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 18:09 Jonathan Wakely
2015-03-11 18:16 ` Jakub Jelinek
2015-03-11 18:42 ` Jonathan Wakely
2015-04-07 8:38 ` Gerald Pfeifer
2015-04-07 8:41 ` Jakub Jelinek
2015-04-07 9:10 ` Jonathan Wakely
2015-04-09 23:28 ` Gerald Pfeifer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1504100126530.9357@tuna.site \
--to=gerald@pfeifer.com \
--cc=3dw4rd@verizon.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jwakely@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).