Re: [C/C++ PATCH] -Wlogical-not-parentheses tweaks (PR c/65120)

[Gerald Pfeifer <gerald@pfeifer.com>]

On Fri, 20 Feb 2015, Jakub Jelinek wrote:
> As reported, !!x == y is quite common in the Linux kernel and unlike the 
> !x == y case it usually doesn't mean mistyped !(x == y) or x != y.  
> clang++ apparently doesn't warn about that either, and it doesn't warn 
> even about the case where ! is applied to a bool.  As the argument is 
> already folded, it isn't easy to determine those cases always, but I 
> hope the following is sufficient until we switch to late folding.

For what it's worth, with this change you eliminated all except
for four false positives in the entire Wine codebase.  And those
four are really only one (times four) and can be avoided easily
apparently.

So, good stuff to begin with, and with these improvements even
more useful.

Thank you!

Gerald