From: Gerald Pfeifer <gerald@pfeifer.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: "Jason Merrill" <jason@redhat.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
"Manuel López-Ibáñez" <lopezibanez@gmail.com>,
"Gcc Patch List" <gcc-patches@gcc.gnu.org>,
"Richard Biener" <richard.guenther@gmail.com>,
"Siddhesh Poyarekar" <siddhesh@redhat.com>,
"Carlos O'Donell" <carlos@redhat.com>,
"GNU C Library" <libc-alpha@sourceware.org>
Subject: Re: [PATCH] -Wmemset-transposed-args (PR middle-end/61294, take 2)
Date: Sun, 12 Apr 2015 19:30:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.20.1504122125070.9357@tuna.site> (raw)
In-Reply-To: <20140711201852.GD31640@tucnak.redhat.com>
Hi Jakub,
On Fri, 11 Jul 2014, Jakub Jelinek wrote:
> So like this? Also have fixed one omitted line in c-parser.c,
> this patch bootstrapped/regtested fine:
just in time for GCC 5.1 RC1 :-) a small update on top of yours.
Committed.
Gerald
2015-04-12 Gerald Pfeifer <gerald@pfeifer.com>
* doc/invoke.texi (-Wmemset-transposed-args): Break a long
sentence. Improve grammar.
Index: doc/invoke.texi
===================================================================
--- doc/invoke.texi (revision 222021)
+++ doc/invoke.texi (working copy)
@@ -4909,10 +4909,10 @@
second argument is not zero and the third argument is zero. This warns e.g.@
about @code{memset (buf, sizeof buf, 0)} where most probably
@code{memset (buf, 0, sizeof buf)} was meant instead. The diagnostics
-is only emitted if the third argument is literal zero, if it is some expression
-that is folded to zero, or e.g. a cast of zero to some type etc., it
-is far less likely that user has mistakenly exchanged the arguments and
-no warning is emitted. This warning is enabled by @option{-Wall}.
+is only emitted if the third argument is literal zero. If it is some
+expression that is folded to zero, a cast of zero to some type, etc.,
+it is far less likely that the user has mistakenly exchanged the arguments
+and no warning is emitted. This warning is enabled by @option{-Wall}.
@item -Waddress
@opindex Waddress
prev parent reply other threads:[~2015-04-12 19:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 14:40 [RFC PATCH] -Wmemset-transposed-args (PR middle-end/61294) Manuel López-Ibáñez
2014-07-09 21:28 ` Jason Merrill
2014-07-10 12:52 ` [PATCH] -Wmemset-transposed-args (PR middle-end/61294, take 2) Jakub Jelinek
2014-07-10 17:57 ` Jason Merrill
2014-07-10 23:29 ` Gerald Pfeifer
2014-07-11 20:19 ` Jakub Jelinek
2015-04-12 19:30 ` Gerald Pfeifer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1504122125070.9357@tuna.site \
--to=gerald@pfeifer.com \
--cc=carlos@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=lopezibanez@gmail.com \
--cc=richard.guenther@gmail.com \
--cc=siddhesh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).