From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46954 invoked by alias); 15 Jul 2015 13:04:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 46943 invoked by uid 89); 15 Jul 2015 13:04:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx2.suse.de Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 15 Jul 2015 13:04:27 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 02C01ABA5; Wed, 15 Jul 2015 13:04:24 +0000 (UTC) Date: Wed, 15 Jul 2015 13:25:00 -0000 From: Michael Matz To: Jim Wilson cc: Richard Earnshaw , Richard Biener , Jeff Law , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH, ARM] stop changing signedness in PROMOTE_MODE In-Reply-To: Message-ID: References: <559BEB2D.7040800@redhat.com> <55A53519.6040305@foss.arm.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg01272.txt.bz2 Hi, On Tue, 14 Jul 2015, Jim Wilson wrote: > Now that we do have the problem, we can't fix it without an ARM port ABI > change, which is undesirable, so we may have to fix it with a MI change. What's the ABI implication of fixing the inconsistency? > There were two MI changes suggested, one was fixing the out-of-ssa pass > to handle SUBREG_PROMOTED_P promotions. The other was to disallow > creating PHI nodes between parms and locals. I haven't had a chance to > try implementing the second one yet; I hope to work on that today. Don't bother with the latter, it doesn't have a chance of being accepted. If the terrible hack in outof-ssa really will be necessary (and I really really hope it won't) then I think I prefer the approach you partly tried in comment #12 of PR 65932 already. Let partition_to_pseudo[] refer to the promoted subreg and deal with that situation in emit_partition_copy; I'd then hope that the unsignedsrcp parameter could go away (unfortunately the sizeexp will have to stay). Ciao, Michael.