From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18809 invoked by alias); 11 Sep 2015 13:55:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18779 invoked by uid 89); 11 Sep 2015 13:55:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Fri, 11 Sep 2015 13:55:31 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id DF8C1ADDC; Fri, 11 Sep 2015 13:55:27 +0000 (UTC) Date: Fri, 11 Sep 2015 14:08:00 -0000 From: Michael Matz To: David Malcolm cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 07/22] Implement token range tracking within libcpp and C/C++ FEs In-Reply-To: <1441916913-11547-8-git-send-email-dmalcolm@redhat.com> Message-ID: References: <1441916913-11547-1-git-send-email-dmalcolm@redhat.com> <1441916913-11547-8-git-send-email-dmalcolm@redhat.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00800.txt.bz2 Hi, On Thu, 10 Sep 2015, David Malcolm wrote: > Does anyone know why this was "carefully packed" and to what extent > this matters? I'm adding an extra 8 bytes to it (or 4 if we eliminate > the existing location_t). As far as I can see, these are > short-lived, and there are only relative few alive at any time. The c++ frontend stores _all_ tokens before starting to parse, so the size of cp_token is not totally irrelevant. It still might not matter much, though. Ciao, Michael.