public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Mark Wielaard <mjw@redhat.com>
Cc: Bernd Schmidt <bschmidt@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] PR28901 -Wunused-variable ignores unused const initialised variables
Date: Thu, 17 Sep 2015 12:41:00 -0000	[thread overview]
Message-ID: <alpine.LSU.2.20.1509171356131.3004@tuna.site> (raw)
In-Reply-To: <20150913114057.GB4445@blokker.redhat.com>

On Sun, 13 Sep 2015, Mark Wielaard wrote:
> Slightly adjusted patch attached. Now it is explicit that the warning is
> enabled by -Wunused-variable for C, but not C++. There are testcases for
> both C and C++ to check the defaults. And the hardcoded override is
> removed for C++, so the user could enable it if they want.

I believe making -Wunused-const-variable part of -Wall is not
a good idea.

For example, I have a nightly build of Wine with a nightly build 
of GCC.  And my notifaction mail went from twently lines of warning 
to 6500 -- all coming from header files.

Gerald

  parent reply	other threads:[~2015-09-17 12:02 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11 22:29 Mark Wielaard
2015-09-11 22:40 ` Bernd Schmidt
2015-09-13  5:44   ` Mark Wielaard
2015-09-13 12:51     ` Mark Wielaard
2015-09-13 13:36       ` Manuel López-Ibáñez
2015-09-13 18:50         ` Mark Wielaard
2015-09-14  7:54           ` Bernd Schmidt
2015-09-15 17:04             ` Steve Ellcey
2015-09-15 17:10               ` Jakub Jelinek
2015-09-15 17:26                 ` Steve Ellcey
2015-09-15 18:55                   ` Mark Wielaard
2015-09-15 19:21                     ` Mark Wielaard
2015-09-15 19:58                     ` Joseph Myers
2015-09-19  2:57                   ` Martin Sebor
2015-09-21 17:10                     ` Steve Ellcey
2015-09-23 18:26                     ` Jeff Law
2015-09-24 12:54                       ` Mark Wielaard
2015-09-24 13:06                         ` Bernd Schmidt
2015-09-24 16:38                           ` Steve Ellcey
2015-09-24 18:40                             ` Bernd Schmidt
2015-09-25  8:00                               ` Trevor Saunders
2015-10-06 22:44                                 ` Steve Ellcey
2015-10-07 12:00                                   ` Bernd Schmidt
2015-10-24 15:00                                     ` Gerald Pfeifer
2015-10-24 15:11                                       ` Mark Wielaard
2016-02-21  1:43                           ` [PATCH] PR28901 Add two levels for -Wunused-const-variable Mark Wielaard
2016-02-22 18:58                             ` Jeff Law
2016-02-22 19:00                               ` Jakub Jelinek
2016-02-22 19:02                                 ` Jeff Law
2016-02-22 22:43                               ` Mark Wielaard
2016-02-23  3:21                                 ` H.J. Lu
2016-02-23  7:55                                   ` Mark Wielaard
2016-02-23  8:27                                     ` Jakub Jelinek
2016-02-23  8:54                                       ` Mark Wielaard
2016-02-23  8:57                                         ` Jakub Jelinek
2016-02-23  9:51                                           ` Manuel López-Ibáñez
2016-02-23  9:55                                             ` Jakub Jelinek
2016-02-23 12:10                                             ` Mark Wielaard
2015-09-15 17:20               ` [PATCH] PR28901 -Wunused-variable ignores unused const initialised variables Joseph Myers
2015-09-17 12:41       ` Gerald Pfeifer [this message]
2015-09-17 16:27         ` Bernd Schmidt
2015-09-17 16:32           ` Mark Wielaard
2015-10-23 23:41             ` Gerald Pfeifer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.20.1509171356131.3004@tuna.site \
    --to=gerald@pfeifer.com \
    --cc=bschmidt@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mjw@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).