From: Gerald Pfeifer <gerald@pfeifer.com>
To: gcc-patches@gcc.gnu.org, David Malcolm <dmalcolm@redhat.com>
Cc: Andriy Gapon <avg@FreeBSD.org>
Subject: Re: stray warning from gcc's cpp
Date: Thu, 01 Sep 2016 16:24:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.20.1609011821200.3437@anthias.pfeifer.com> (raw)
In-Reply-To: <5335901A.6080107@FreeBSD.org>
Hi David,
I found this older report (including patches for two approaches
even!) that it seems did not see any response despite the nice
analysis (and the patch).
Mind having a look?
Gerald
PS: If you prefer, I can put this into Bugzilla, too.
On Fri, 28 Mar 2014, Andriy Gapon wrote:
> on 19/03/2014 12:03 Andriy Gapon said the following:
>>
>> I observe the following minor annoyance on FreeBSD systems where cpp is GCC's
>> cpp. If a DTrace script has the following shebang line:
>> #!/usr/sbin/dtrace -Cs
>> then the following warning is produced when the script is run:
>> cc1: warning: is shorter than expected
>>
>> Some details. dtrace(1) first forks. Then a child seeks on a file
>> descriptor associated with the script file, so that the shebang line is
>> skipped (because otherwise it would confuse cpp). Then the child makes
>> the file descriptor its standard input and then it execs cpp. cpp
>> performs fstat(2) on its standard input descriptor and determines that
>> it points to a regular file. Then it verifies that a number of bytes
>> it reads from the file is the same as a size of the file. The check
>> makes sense if the file is opened by cpp itself, but it does not always
>> make sense for the stdin as described above.
>>
>> The following patch seems to fix the issue, but perhaps there is a
>> better / smarter alternative.
> A patch that implements a different approach has been committed in FreeBSD:
> https://github.com/freebsd/freebsd/commit/6ceec4444ddbc
> Please consider. Thanks!
>
>> --- a/libcpp/files.c
>> +++ b/libcpp/files.c
>> @@ -601,7 +601,8 @@ read_file_guts (cpp_reader *pfile, _cpp_file *file)
>> return false;
>> }
>>
>> - if (regular && total != size && STAT_SIZE_RELIABLE (file->st))
>> + if (regular && total != size && file->fd != 0
>> + && STAT_SIZE_RELIABLE (file->st))
>> cpp_error (pfile, CPP_DL_WARNING,
>> "%s is shorter than expected", file->path);
prev parent reply other threads:[~2016-09-01 16:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 10:32 Andriy Gapon
2014-03-28 15:19 ` Andriy Gapon
2016-09-01 16:24 ` Gerald Pfeifer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1609011821200.3437@anthias.pfeifer.com \
--to=gerald@pfeifer.com \
--cc=avg@FreeBSD.org \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).