* [PATCH] Update BUGURL
@ 2017-02-09 8:31 Gerald Pfeifer
2017-02-09 8:56 ` libcpp BUGURL (was: [PATCH] Update BUGURL) Gerald Pfeifer
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Gerald Pfeifer @ 2017-02-09 8:31 UTC (permalink / raw)
To: gcc-patches
As Jakub also pointed out, there are various places where our
BUGURL is defined (not just used).
For libstdc++, Jonathan already filed gcc.gnu.org/PR79422, and
I'll tackle the others one by one, involving the respective
maintainers to see whether there is more to be done than just
updating the string.
Gerald
2017-02-09 Gerald Pfeifer <gerald@pfeifer.com>
* configure.ac (ACX_BUGURL): Update.
* configure: Regenerate.
Index: configure.ac
===================================================================
--- configure.ac (revision 245295)
+++ configure.ac (working copy)
@@ -930,7 +930,7 @@
AC_SUBST(CONFIGURE_SPECS)
ACX_PKGVERSION([GCC])
-ACX_BUGURL([http://gcc.gnu.org/bugs.html])
+ACX_BUGURL([https://gcc.gnu.org/bugs/])
# Sanity check enable_languages in case someone does not run the toplevel
# configure # script.
Index: configure
===================================================================
--- configure (revision 245295)
+++ configure (working copy)
@@ -7655,7 +7655,7 @@
;;
esac
else
- BUGURL="http://gcc.gnu.org/bugs.html"
+ BUGURL="https://gcc.gnu.org/bugs/"
fi
^ permalink raw reply [flat|nested] 6+ messages in thread
* libcpp BUGURL (was: [PATCH] Update BUGURL)
2017-02-09 8:31 [PATCH] Update BUGURL Gerald Pfeifer
@ 2017-02-09 8:56 ` Gerald Pfeifer
2017-02-09 10:59 ` libquadmath " Gerald Pfeifer
2017-02-09 14:23 ` [PATCH] Introduce BUGURL in gcc/po/exgettext " Gerald Pfeifer
2 siblings, 0 replies; 6+ messages in thread
From: Gerald Pfeifer @ 2017-02-09 8:56 UTC (permalink / raw)
To: gcc-patches, Joseph S. Myers, David Malcolm
Cc: Richard Henderson, Jason Merrill, Nathan Sidwell
[ Copying libcpp maintainers ]
On Thu, 9 Feb 2017, Gerald Pfeifer wrote:
> As Jakub also pointed out, there are various places where our
> BUGURL is defined (not just used).
This is the patch for libcpp.
Applied for now, though I'm wondering whether there's more than just
updating the URL that you may want to look into (so that we don't have
it hardcoded in so many places)?
Gerald
2017-02-09 Gerald Pfeifer <gerald@pfeifer.com>
* Makefile.in (po/$(PACKAGE).pot): Adjust bug reporting URL.
Index: Makefile.in
===================================================================
--- Makefile.in (revision 245296)
+++ Makefile.in (working copy)
@@ -256,7 +256,7 @@
--keyword=cpp_errno:3 \
--keyword=SYNTAX_ERROR --keyword=SYNTAX_ERROR2 \
--copyright-holder="Free Software Foundation, Inc." \
- --msgid-bugs-address="http://gcc.gnu.org/bugs.html" \
+ --msgid-bugs-address="https://gcc.gnu.org/bugs/" \
--language=c -o po/$(PACKAGE).pot.tmp $^
sed 's:$(srcdir)/::g' <po/$(PACKAGE).pot.tmp >po/$(PACKAGE).pot
rm po/$(PACKAGE).pot.tmp
^ permalink raw reply [flat|nested] 6+ messages in thread
* libquadmath BUGURL (was: [PATCH] Update BUGURL)
2017-02-09 8:31 [PATCH] Update BUGURL Gerald Pfeifer
2017-02-09 8:56 ` libcpp BUGURL (was: [PATCH] Update BUGURL) Gerald Pfeifer
@ 2017-02-09 10:59 ` Gerald Pfeifer
2017-02-09 11:01 ` Jakub Jelinek
2017-02-09 14:23 ` [PATCH] Introduce BUGURL in gcc/po/exgettext " Gerald Pfeifer
2 siblings, 1 reply; 6+ messages in thread
From: Gerald Pfeifer @ 2017-02-09 10:59 UTC (permalink / raw)
To: gcc-patches, Tobias Burnus, Jakub Jelinek
[ Copying libquadmath maintainers ]
On Thu, 9 Feb 2017, Gerald Pfeifer wrote:
> As Jakub also pointed out, there are various places where our
> BUGURL is defined (not just used).
This is the patch for libquadmath.
Applied for now, though I'm wondering whether indeed we do have to
redefine this here (versus reusing a more centralized definition)?
Gerald
2017-02-09 Gerald Pfeifer <gerald@pfeifer.com>
* configure.ac (ACX_BUGURL): Update.
* configure: Regenerate.
Index: libquadmath/configure.ac
===================================================================
--- libquadmath/configure.ac (revision 245298)
+++ libquadmath/configure.ac (working copy)
@@ -53,7 +53,7 @@
[4.[4-9]*|4.[1-9][0-9]*|[5-9]*|[1-9][0-9]*])
AM_CONDITIONAL(BUILD_INFO, test $gcc_cv_prog_makeinfo_modern = "yes")
-ACX_BUGURL([http://gcc.gnu.org/bugs.html])
+ACX_BUGURL([https://gcc.gnu.org/bugs/])
# Configure libtool
AM_PROG_LIBTOOL
Index: libquadmath/configure
===================================================================
--- libquadmath/configure (revision 245298)
+++ libquadmath/configure (working copy)
@@ -4446,7 +4446,7 @@
;;
esac
else
- BUGURL="http://gcc.gnu.org/bugs.html"
+ BUGURL="https://gcc.gnu.org/bugs/"
fi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: libquadmath BUGURL (was: [PATCH] Update BUGURL)
2017-02-09 10:59 ` libquadmath " Gerald Pfeifer
@ 2017-02-09 11:01 ` Jakub Jelinek
0 siblings, 0 replies; 6+ messages in thread
From: Jakub Jelinek @ 2017-02-09 11:01 UTC (permalink / raw)
To: Gerald Pfeifer; +Cc: gcc-patches, Tobias Burnus
On Thu, Feb 09, 2017 at 11:59:36AM +0100, Gerald Pfeifer wrote:
> [ Copying libquadmath maintainers ]
>
> On Thu, 9 Feb 2017, Gerald Pfeifer wrote:
> > As Jakub also pointed out, there are various places where our
> > BUGURL is defined (not just used).
>
> This is the patch for libquadmath.
>
> Applied for now, though I'm wondering whether indeed we do have to
> redefine this here (versus reusing a more centralized definition)?
>
> Gerald
>
> 2017-02-09 Gerald Pfeifer <gerald@pfeifer.com>
>
> * configure.ac (ACX_BUGURL): Update.
> * configure: Regenerate.
LGTM, thanks.
Jakub
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Introduce BUGURL in gcc/po/exgettext (was: [PATCH] Update BUGURL)
2017-02-09 8:31 [PATCH] Update BUGURL Gerald Pfeifer
2017-02-09 8:56 ` libcpp BUGURL (was: [PATCH] Update BUGURL) Gerald Pfeifer
2017-02-09 10:59 ` libquadmath " Gerald Pfeifer
@ 2017-02-09 14:23 ` Gerald Pfeifer
2017-02-13 23:33 ` [PATCH] Introduce BUGURL in gcc/po/exgettext Jeff Law
2 siblings, 1 reply; 6+ messages in thread
From: Gerald Pfeifer @ 2017-02-09 14:23 UTC (permalink / raw)
To: gcc-patches, Jakub Jelinek
On Thu, 9 Feb 2017, Gerald Pfeifer wrote:
> As Jakub also pointed out, there are various places where our
> BUGURL is defined (not just used).
So, this one I found particularly interesting.
The same URL is used four times in the same file, which begs for
a little abstraction. ;-) I did that, and adjusted the link (once).
Okay with a proper ChangeLog entry?
Gerald
Index: gcc/po/exgettext
===================================================================
--- gcc/po/exgettext (revision 245299)
+++ gcc/po/exgettext (working copy)
@@ -21,6 +21,8 @@
# along with GCC; see the file COPYING3. If not see
# <http://www.gnu.org/licenses/>.
+BUGURL="https://gcc.gnu.org/bugs/"
+
# Always operate in the C locale.
LANG=C
LANGUAGE=C
@@ -293,13 +295,13 @@
$xgettext --default-domain=$package --directory=$srcdir \
--add-comments `cat $kopt` --files-from=$posr \
--copyright-holder="Free Software Foundation, Inc." \
- --msgid-bugs-address="http://gcc.gnu.org/bugs.html" \
+ --msgid-bugs-address="$BUGURL" \
--language=c -o $pottmp1
if test -s $posrcxx; then
$xgettext --default-domain=$package --directory=$srcdir \
--add-comments `cat $kopt` --files-from=$posrcxx \
--copyright-holder="Free Software Foundation, Inc." \
- --msgid-bugs-address="http://gcc.gnu.org/bugs.html" \
+ --msgid-bugs-address="$BUGURL" \
--language=c++ -o $pottmp2
else
echo > $pottmp2
@@ -307,12 +309,12 @@
$xgettext --default-domain=$package --directory=$srcdir \
--add-comments --keyword= `cat $kopt2` --files-from=$posr \
--copyright-holder="Free Software Foundation, Inc." \
- --msgid-bugs-address="http://gcc.gnu.org/bugs.html" \
+ --msgid-bugs-address="$BUGURL" \
--language=GCC-source -o $pottmp3
$xgettext --default-domain=$package \
--add-comments $pottmp1 $pottmp2 $pottmp3 \
--copyright-holder="Free Software Foundation, Inc." \
- --msgid-bugs-address="http://gcc.gnu.org/bugs.html" \
+ --msgid-bugs-address="$BUGURL" \
--language=PO -o $pottmp
# Remove local paths from .pot file.
sed "s:$srcdir/::g;s:$pwd/::g;" <$pottmp >po/$package.pot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Introduce BUGURL in gcc/po/exgettext
2017-02-09 14:23 ` [PATCH] Introduce BUGURL in gcc/po/exgettext " Gerald Pfeifer
@ 2017-02-13 23:33 ` Jeff Law
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Law @ 2017-02-13 23:33 UTC (permalink / raw)
To: Gerald Pfeifer, gcc-patches, Jakub Jelinek
On 02/09/2017 07:23 AM, Gerald Pfeifer wrote:
> On Thu, 9 Feb 2017, Gerald Pfeifer wrote:
>> As Jakub also pointed out, there are various places where our
>> BUGURL is defined (not just used).
>
> So, this one I found particularly interesting.
>
> The same URL is used four times in the same file, which begs for
> a little abstraction. ;-) I did that, and adjusted the link (once).
>
> Okay with a proper ChangeLog entry?
Of course.
jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-02-13 23:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-09 8:31 [PATCH] Update BUGURL Gerald Pfeifer
2017-02-09 8:56 ` libcpp BUGURL (was: [PATCH] Update BUGURL) Gerald Pfeifer
2017-02-09 10:59 ` libquadmath " Gerald Pfeifer
2017-02-09 11:01 ` Jakub Jelinek
2017-02-09 14:23 ` [PATCH] Introduce BUGURL in gcc/po/exgettext " Gerald Pfeifer
2017-02-13 23:33 ` [PATCH] Introduce BUGURL in gcc/po/exgettext Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).