From: Richard Biener <rguenther@suse.de>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix PR79547
Date: Fri, 21 Apr 2017 13:08:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.20.1704211445490.24645@zhemvz.fhfr.qr> (raw)
In-Reply-To: <alpine.LSU.2.20.1702171042390.8538@zhemvz.fhfr.qr>
On Fri, 17 Feb 2017, Richard Biener wrote:
> On Thu, 16 Feb 2017, Richard Biener wrote:
>
> >
> > I am testing the following patch for PR79547. Those builtins do not
> > return anything that can be used to re-construct the pointer(s) passed
> > to them.
> >
> > Queued for GCC 8.
>
> Actually we need calluse constraints. Thus adjusted as follows.
Re-bootstrapped & tested on x86_64-unknown-linux-gnu, applied to trunk.
Richard.
> Richard.
>
> 2017-02-17 Richard Biener <rguenther@suse.de>
>
> PR tree-optimization/79547
> * tree-ssa-structalias.c (find_func_aliases_for_builtin_call):
> Handle strlen, strcmp, strncmp, strcasecmp, strncasecmp, memcmp,
> bcmp, strspn, strcspn, __builtin_object_size and __builtin_constant_p
> without any constraints.
>
> * gcc.dg/tree-ssa/strlen-2.c: New testcase.
>
> Index: gcc/testsuite/gcc.dg/tree-ssa/strlen-2.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/tree-ssa/strlen-2.c (nonexistent)
> +++ gcc/testsuite/gcc.dg/tree-ssa/strlen-2.c (working copy)
> @@ -0,0 +1,15 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O2 -fdump-tree-strlen" } */
> +
> +void f (unsigned);
> +
> +void f3 (void)
> +{
> + char s[] = "1234";
> +
> + f (__builtin_strlen (s));
> + f (__builtin_strlen (s));
> + f (__builtin_strlen (s));
> +}
> +
> +/* { dg-final { scan-tree-dump-times "strlen" 1 "strlen" } } */
> Index: gcc/tree-ssa-structalias.c
> ===================================================================
> --- gcc/tree-ssa-structalias.c (revision 245501)
> +++ gcc/tree-ssa-structalias.c (working copy)
> @@ -4474,6 +4474,40 @@ find_func_aliases_for_builtin_call (stru
> process_all_all_constraints (lhsc, rhsc);
> }
> return true;
> + /* Pure functions that return something not based on any object and
> + that use the memory pointed to by their arguments (but not
> + transitively). */
> + case BUILT_IN_STRCMP:
> + case BUILT_IN_STRNCMP:
> + case BUILT_IN_STRCASECMP:
> + case BUILT_IN_STRNCASECMP:
> + case BUILT_IN_MEMCMP:
> + case BUILT_IN_BCMP:
> + case BUILT_IN_STRSPN:
> + case BUILT_IN_STRCSPN:
> + {
> + varinfo_t uses = get_call_use_vi (t);
> + make_any_offset_constraints (uses);
> + make_constraint_to (uses->id, gimple_call_arg (t, 0));
> + make_constraint_to (uses->id, gimple_call_arg (t, 1));
> + /* No constraints are necessary for the return value. */
> + return true;
> + }
> + case BUILT_IN_STRLEN:
> + {
> + varinfo_t uses = get_call_use_vi (t);
> + make_any_offset_constraints (uses);
> + make_constraint_to (uses->id, gimple_call_arg (t, 0));
> + /* No constraints are necessary for the return value. */
> + return true;
> + }
> + case BUILT_IN_OBJECT_SIZE:
> + case BUILT_IN_CONSTANT_P:
> + {
> + /* No constraints are necessary for the return value or the
> + arguments. */
> + return true;
> + }
> /* Trampolines are special - they set up passing the static
> frame. */
> case BUILT_IN_INIT_TRAMPOLINE:
>
>
--
Richard Biener <rguenther@suse.de>
SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)
prev parent reply other threads:[~2017-04-21 12:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 12:47 Richard Biener
2017-02-17 9:45 ` Richard Biener
2017-02-17 10:52 ` Marc Glisse
2017-02-17 11:32 ` Richard Biener
2017-04-21 13:08 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1704211445490.24645@zhemvz.fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).