[PATCH] Increase expect match buffer size

[PATCH] Increase expect match buffer size

[Bernd Edlinger]

[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

Hi,


this is to mitigate a race condition in expect 5.45-7
(which will be fixed in 5.45-8) see this thread for details:

https://gcc.gnu.org/ml/gcc/2017-07/msg00081.html

By increasing the match buffer size from 2000 to 10000
bytes we can avoid the fall-out due to the bug in expect,
while we have to wait for the next stable debian version.


Bootstrapped and reg-tested on x86_64-pc-linux-gnu.
Is it OK for trunk?


Thanks
Bernd.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch-match-max.diff --]
[-- Type: text/x-patch; name="patch-match-max.diff", Size: 585 bytes --]

2017-07-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>

        * lib/gcc-dg.exp: Increase expect's match buffer size.

Index: gcc/testsuite/lib/gcc-dg.exp
===================================================================
--- gcc/testsuite/lib/gcc-dg.exp	(revision 250150)
+++ gcc/testsuite/lib/gcc-dg.exp	(working copy)
@@ -43,6 +43,9 @@
   setenv LANG C.ASCII
 }
 
+# Avoid sporadic data-losses with expect
+match_max -d 10000
+
 # Ensure GCC_COLORS is unset, for the rare testcases that verify
 # how output is colorized.
 if [info exists ::env(GCC_COLORS) ] {

Re: [PATCH] Increase expect match buffer size

[Richard Biener]

On Mon, 17 Jul 2017, Bernd Edlinger wrote:

> Hi,
> 
> 
> this is to mitigate a race condition in expect 5.45-7
> (which will be fixed in 5.45-8) see this thread for details:
> 
> https://gcc.gnu.org/ml/gcc/2017-07/msg00081.html
> 
> By increasing the match buffer size from 2000 to 10000
> bytes we can avoid the fall-out due to the bug in expect,
> while we have to wait for the next stable debian version.
> 
> 
> Bootstrapped and reg-tested on x86_64-pc-linux-gnu.
> Is it OK for trunk?

Ok.

Richard.