From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128582 invoked by alias); 26 Jul 2017 10:34:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 127874 invoked by uid 89); 26 Jul 2017 10:34:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1111 X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Jul 2017 10:34:12 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 972CDAB1E; Wed, 26 Jul 2017 10:34:10 +0000 (UTC) Date: Wed, 26 Jul 2017 10:34:00 -0000 From: Richard Biener To: Jakub Jelinek cc: Jan Hubicka , gcc-patches@gcc.gnu.org Subject: Re: Patch ping In-Reply-To: <20170725094050.GR2123@tucnak> Message-ID: References: <20170725094050.GR2123@tucnak> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-SW-Source: 2017-07/txt/msg01648.txt.bz2 On Tue, 25 Jul 2017, Jakub Jelinek wrote: > Hi! > > I'd like to ping 2 patches: > > - UBSAN -fsanitize=pointer-overflow support > - http://gcc.gnu.org/ml/gcc-patches/2017-06/msg01365.html The probablility stuff might need updating? Can you put the TYPE_PRECISION (sizetype) != POINTER_SIZE check in option processing and inform people that pointer overflow sanitizing is not done instead? Where you handle DECL_BIT_FIELD_REPRESENTATIVE in maybe_instrument_pointer_overflow you could instead of building a new COMPONENT_REF strip the bitfield ref and just remember DECL_FIELD_OFFSET/BIT_OFFSET to be added to the get_inner_reference result? You don't seem to use 'size' anywhere. You fail to allow other handled components -- for no good reason? You fail to handle &MEM[ptr + CST] a canonical gimple invariant way of ptr +p CST, the early out bitpos == 0 will cause non-instrumentation here. (I'd just round down in the case of bitpos % BITS_PER_UNIT != 0) Otherwise looks good. > - noipa attribute addition > http://gcc.gnu.org/ml/gcc-patches/2016-12/msg01501.html Ok. Thanks, Richard.