From: Richard Biener <rguenther@suse.de>
To: Tamar Christina <Tamar.Christina@arm.com>
Cc: Vidya Praveen <vidyapraveen@arm.com>,
Andrew Pinski <pinskia@gmail.com>,
Andreas Schwab <schwab@linux-m68k.org>,
Jon Beniston <jon@beniston.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
nd <nd@arm.com>
Subject: RE: [RFC, vectorizer] Allow single element vector types for vector reduction operations
Date: Tue, 12 Sep 2017 10:50:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.20.1709121250180.26836@zhemvz.fhfr.qr> (raw)
In-Reply-To: <alpine.LSU.2.20.1709121103030.26836@zhemvz.fhfr.qr>
On Tue, 12 Sep 2017, Richard Biener wrote:
> On Tue, 12 Sep 2017, Tamar Christina wrote:
>
> > Hi Jon, Richard,
> >
> > > > >
> > > > > Testing the following instead:
> > > >
> > > > Any news on this?
> > >
> > > Didn't work out as expected. I think the logic in tree-vect-generic is the one
> > > to be fixed but I have to carve out some time to look into it so stay tuned.
> >
> > In the meantime can this patch be reverted? It is causing ICEs on
> > AArch64 and ARM Preventing us from building benchmarks and tracking the
> > toolchain performance.
>
> You can always locally patch things. I have yet another patch in
> testing right now.
I've installed the following.
Bootstrapped and tested on x86_64-unknown-linux-gnu.
Richard.
2017-09-12 Richard Biener <rguenther@suse.de>
* tree-vect-generic.c (expand_vector_operations_1): Do nothing
for operations we cannot scalarize.
Index: gcc/tree-vect-generic.c
===================================================================
--- gcc/tree-vect-generic.c (revision 251997)
+++ gcc/tree-vect-generic.c (working copy)
@@ -1638,7 +1638,11 @@ expand_vector_operations_1 (gimple_stmt_
/* The signedness is determined from input argument. */
if (code == VEC_UNPACK_FLOAT_HI_EXPR
|| code == VEC_UNPACK_FLOAT_LO_EXPR)
- type = TREE_TYPE (rhs1);
+ {
+ type = TREE_TYPE (rhs1);
+ /* We do not know how to scalarize those. */
+ return;
+ }
/* For widening/narrowing vector operations, the relevant type is of the
arguments, not the widened result. VEC_UNPACK_FLOAT_*_EXPR is
@@ -1655,7 +1659,11 @@ expand_vector_operations_1 (gimple_stmt_
|| code == VEC_PACK_FIX_TRUNC_EXPR
|| code == VEC_WIDEN_LSHIFT_HI_EXPR
|| code == VEC_WIDEN_LSHIFT_LO_EXPR)
- type = TREE_TYPE (rhs1);
+ {
+ type = TREE_TYPE (rhs1);
+ /* We do not know how to scalarize those. */
+ return;
+ }
/* Choose between vector shift/rotate by vector and vector shift/rotate by
scalar */
next prev parent reply other threads:[~2017-09-12 10:50 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 8:22 Jon Beniston
2017-08-28 8:29 ` Richard Biener
2017-08-28 9:04 ` Jon Beniston
2017-08-28 11:41 ` Richard Biener
2017-08-30 11:13 ` Jon Beniston
2017-08-30 12:28 ` Richard Biener
2017-08-30 15:52 ` Jon Beniston
2017-08-30 16:32 ` Richard Biener
2017-08-30 20:42 ` Richard Sandiford
2017-09-02 21:58 ` Andreas Schwab
2017-09-04 8:58 ` Tamar Christina
2017-09-04 9:19 ` Richard Biener
2017-09-04 14:28 ` Tamar Christina
2017-09-04 16:48 ` Andrew Pinski
2017-09-05 9:37 ` Richard Biener
2017-09-05 10:24 ` Tamar Christina
2017-09-05 10:41 ` Richard Biener
2017-09-05 12:50 ` Richard Biener
2017-09-05 13:06 ` Tamar Christina
2017-09-05 13:12 ` Richard Biener
2017-09-05 14:00 ` Tamar Christina
2017-09-11 15:39 ` Vidya Praveen
2017-09-12 7:13 ` Richard Biener
2017-09-12 8:45 ` Tamar Christina
2017-09-12 9:03 ` Richard Biener
2017-09-12 10:50 ` Richard Biener [this message]
2017-09-12 16:26 ` Andreas Schwab
2017-09-12 16:36 ` Richard Biener
2017-09-12 17:13 ` Tamar Christina
2017-09-04 15:04 ` Christophe Lyon
2017-09-07 11:08 ` Bernd Schmidt
2017-09-07 11:20 ` Jon Beniston
2017-09-07 14:42 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1709121250180.26836@zhemvz.fhfr.qr \
--to=rguenther@suse.de \
--cc=Tamar.Christina@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jon@beniston.com \
--cc=nd@arm.com \
--cc=pinskia@gmail.com \
--cc=schwab@linux-m68k.org \
--cc=vidyapraveen@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).