From: Richard Biener <rguenther@suse.de>
To: Nathan Sidwell <nathan@acm.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jeff Law <law@redhat.com>
Subject: Re: [PATCH PR/82546] tree node size
Date: Tue, 17 Oct 2017 09:27:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.20.1710171123410.5588@zhemvz.fhfr.qr> (raw)
In-Reply-To: <4fb6d651-76af-4891-a37f-9436257aa090@acm.org>
On Mon, 16 Oct 2017, Nathan Sidwell wrote:
> On 10/16/2017 02:49 AM, Richard Biener wrote:
> > On October 13, 2017 8:29:40 PM GMT+02:00, Nathan Sidwell <nathan@acm.org>
> > wrote:
>
> > > I intend to continue cleaning this up of course. It's not clear to me
> > > whether we should cache these node sizes in an array, and the way it
> > > goes about checking nodes with nested switches is understandable, but
> > > possible not the fastest solution. However let's at least get the
> > > sizing
> > > right first.
> >
> > We were conservative exactly to avoid the langhook here. I think there's
> > similar 'bug' on the decl side.
>
> The other code types (decls, exprs, etc) call the langhook. tcc_type seems
> the exception (now?).
Sorry for not looking at the patch before replying. The patch looks ok
but shouldn't LANG_TYPE be also handled by the FE? LANG_TYPE itself
is an odd beast if I may say that - it's only used by the C++ and Ada FEs
and the Ada FE does only
/* Make a dummy type corresponding to GNAT_TYPE. */
tree
make_dummy_type (Entity_Id gnat_type)
{
...
/* Create a debug type so that debug info consumers only see an
unspecified
type. */
if (Needs_Debug_Info (gnat_type))
{
debug_type = make_node (LANG_TYPE);
SET_TYPE_DEBUG_TYPE (gnu_type, debug_type);
TYPE_NAME (debug_type) = TYPE_NAME (gnu_type);
TYPE_ARTIFICIAL (debug_type) = TYPE_ARTIFICIAL (gnu_type);
}
Thus the patch is ok.
Thanks,
Richard.
next prev parent reply other threads:[~2017-10-17 9:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 18:32 Nathan Sidwell
2017-10-16 6:53 ` Richard Biener
2017-10-16 10:47 ` Nathan Sidwell
2017-10-17 9:27 ` Richard Biener [this message]
2017-10-17 14:18 ` Nathan Sidwell
2017-10-17 14:29 ` Richard Biener
2017-10-18 10:06 ` Olivier Hainque
2017-10-18 14:03 ` Eric Botcazou
2017-10-19 7:17 ` Olivier Hainque
2017-10-17 19:31 ` Unbreak Ada bootstrap (was Re: [PATCH PR/82546] tree node size) Jakub Jelinek
2017-10-17 20:09 ` Richard Biener
2017-10-17 20:21 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1710171123410.5588@zhemvz.fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).