From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76214 invoked by alias); 24 Jan 2018 11:18:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 76196 invoked by uid 89); 24 Jan 2018 11:18:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Jan 2018 11:18:21 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 90070ACD2; Wed, 24 Jan 2018 11:18:19 +0000 (UTC) Date: Wed, 24 Jan 2018 11:31:00 -0000 From: Richard Biener To: "Koval, Julia" cc: Jakub Jelinek , Uros Bizjak , GCC Patches , Kirill Yukhin Subject: RE: [patch][x86] -march=icelake In-Reply-To: <4E89A029A0F8D443B436A5167BA3C53F8A48C59D@IRSMSX101.ger.corp.intel.com> Message-ID: References: <4E89A029A0F8D443B436A5167BA3C53F8A45EE15@IRSMSX101.ger.corp.intel.com> <4E89A029A0F8D443B436A5167BA3C53F8A461F0A@IRSMSX101.ger.corp.intel.com> <20171219134931.GP2353@tucnak> <4E89A029A0F8D443B436A5167BA3C53F8A48A4CD@IRSMSX101.ger.corp.intel.com> <20180122113610.GF2063@tucnak> <4E89A029A0F8D443B436A5167BA3C53F8A48A54B@IRSMSX101.ger.corp.intel.com> <20180124110548.GA2063@tucnak> <4E89A029A0F8D443B436A5167BA3C53F8A48C59D@IRSMSX101.ger.corp.intel.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-SW-Source: 2018-01/txt/msg02014.txt.bz2 On Wed, 24 Jan 2018, Koval, Julia wrote: > I think we may want to extend it to more than 2 ints someday, when we run out of bits again. It won't break the existing functionality if 3rd int will be zero by default. That's why I tried to avoid "two" in the name. > > Julia > > > -----Original Message----- > > From: Jakub Jelinek [mailto:jakub@redhat.com] > > Sent: Wednesday, January 24, 2018 12:06 PM > > To: Uros Bizjak ; Richard Biener > > Cc: Koval, Julia ; GCC Patches > patches@gcc.gnu.org>; Kirill Yukhin > > Subject: Re: [patch][x86] -march=icelake > > > > On Wed, Jan 24, 2018 at 12:00:26PM +0100, Uros Bizjak wrote: > > > On Mon, Jan 22, 2018 at 3:44 PM, Koval, Julia wrote: > > > > Yes, you are right, any() is not required. Here is the patch. > > > > > > Please also attach ChangeLog. > > > > > > The patch is OK for x86 target, it needs global reviewer approval > > > (Maybe Jakub, as the patch touches OMP part). > > > > I don't like the new class name nor header name, bit_mask is way too generic > > name for something very specialized (double hwi bitmask). > > > > Richard, any suggestions for this? Maybe wide_int_bitmask? You could then even use fixed_wide_int <> as "implementation". Richard.