From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-475347-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 2889 invoked by alias); 23 Mar 2018 11:24:05 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 2854 invoked by uid 89); 23 Mar 2018 11:24:04 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mx2.suse.de
Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Mar 2018 11:24:02 +0000
Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])	by mx2.suse.de (Postfix) with ESMTP id BE5AFAF87;	Fri, 23 Mar 2018 11:24:00 +0000 (UTC)
Date: Fri, 23 Mar 2018 11:35:00 -0000
From: Richard Biener <rguenther@suse.de>
To: Eric Botcazou <ebotcazou@adacore.com>
cc: gcc-patches@gcc.gnu.org, jakub@gcc.gnu.org
Subject: Re: [PATCH] Fix PR85020
In-Reply-To: <6335869.hMGE4pAAGX@polaris>
Message-ID: <alpine.LSU.2.20.1803231223510.18265@zhemvz.fhfr.qr>
References: <alpine.LSU.2.20.1803221411440.18265@zhemvz.fhfr.qr> <6335869.hMGE4pAAGX@polaris>
User-Agent: Alpine 2.20 (LSU 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-SW-Source: 2018-03/txt/msg01283.txt.bz2

On Fri, 23 Mar 2018, Eric Botcazou wrote:

> > This should then trigger the use of DW_OP_GNU_variable_value but
> > for the Ada ACATS testcase I was looking at to debug the issue
> > (c330001, resp. c330001_0-c330001_1.ads) this doesn't work
> > because the constraints are not met (we're in global context and
> > the upper bound decl is global as well).  Jakub, do you remember
> > a reason for having any constraints here?  I've reworked the
> > constraints to allow the globals (eventually using decl_function_context
> > on this may also allow other not-quite-local cases?  But it already
> > allowed local statics).  Maybe we can simply drop the restriction
> > alltogether?
> 
> Thanks for looking into this.
> 
> > Eric, can you generate a gnat.dg LTO testcase from (reduced) c330001?
> 
> Attached.
> 
> 
> 	* gnat.dg/lto22.adb: New test.
> 	* gnat.dg/lto22_pkg1.ad[sb]: New helper.
> 	* gnat.dg/lto22_pkg2.ads: Likewise.

Thanks, committed.

Richard.