From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-476716-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 112893 invoked by alias); 23 Apr 2018 12:08:18 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 112595 invoked by uid 89); 23 Apr 2018 12:08:17 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1511
X-HELO: mx2.suse.de
Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Apr 2018 12:08:16 +0000
Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])	by mx2.suse.de (Postfix) with ESMTP id 2A374AC99;	Mon, 23 Apr 2018 12:08:14 +0000 (UTC)
Date: Mon, 23 Apr 2018 12:11:00 -0000
From: Richard Biener <rguenther@suse.de>
To: Tom de Vries <Tom_deVries@mentor.com>
cc: Jakub Jelinek <jakub@redhat.com>,     Cesar Philippidis <cesar@codesourcery.com>,     "H.J. Lu" <hjl.tools@gmail.com>,     "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, lto, PR85422] Fixup loops before lto write-out
In-Reply-To: <ae3f7acc-033e-186c-7c15-d89b84602b6f@mentor.com>
Message-ID: <alpine.LSU.2.20.1804231407330.31014@zhemvz.fhfr.qr>
References: <b221579c-a194-2404-dd2a-fb9d7f1867e3@codesourcery.com> <20180406141029.GF8577@tucnak> <alpine.LSU.2.20.1804091323510.18265@zhemvz.fhfr.qr> <fdabd312-e110-653c-1269-7edd804ca637@codesourcery.com> <CAMe9rOoBm7BjD9UJqY58-xZL8ud8VxvW-8VSQO2xNXnVZG_gXA@mail.gmail.com> <c44bf66a-aba9-03a7-abfe-2258b197bb5e@codesourcery.com> <20180412185840.GR8577@tucnak> <b574d8e8-586c-43fb-1e6a-5ece2af20237@mentor.com> <ae3f7acc-033e-186c-7c15-d89b84602b6f@mentor.com>
User-Agent: Alpine 2.20 (LSU 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-SW-Source: 2018-04/txt/msg01044.txt.bz2

On Mon, 23 Apr 2018, Tom de Vries wrote:

> [ was: Re: [PATCH] Handle empty infinite loops in OpenACC for PR84955 ]
> 
> On 04/16/2018 08:13 PM, Tom de Vries wrote:
> > On 04/12/2018 08:58 PM, Jakub Jelinek wrote:
> > > On Thu, Apr 12, 2018 at 11:39:43AM -0700, Cesar Philippidis wrote:
> > > > Strange. I didn't observe any regressions when I tested it. But, then
> > > > again, I was testing against revision
> > > > 
> > > > r259092 | jason | 2018-04-04 09:42:55 -0700 (Wed, 04 Apr 2018) | 4 lines
> > > > 
> > > > which is over a week old. I'll revert that patch for now, and revisit
> > > > this issue in stage1.
> > > 
> > > You should have kept the omp-expand.c chunk, that is correct and shouldn't
> > > cause issues.
> > 
> > Committed as attached (with correct changelog entry, the previously
> > committed patch had an incorrect one).
> > 
> > I've filed the lto ICE (described as "the second problem" in this thread) as
> > PR85422 - "[openacc] ICE at cfgloop.c:468: segfault in flow_loops_find".
> > 
> 
> Hi,
> 
> your updated patch [ as posted here (
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85422#c9 ) ]  fixes the
> flow_loops_find segfault, without causing the regressions mentioned here (
> https://gcc.gnu.org/ml/gcc-patches/2018-04/msg00628.html ).
> 
> Build x86_64 with nvptx accelerator, ran libgomp testsuite.
> 
> Bootstrapped and reg-tested x86_64 with -m64/-m32.
> 
> OK for stage4/stage1 trunk?

OK for stage1.

Thanks,
Richard.