From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53610 invoked by alias); 14 May 2018 09:16:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 53599 invoked by uid 89); 14 May 2018 09:16:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:631, Jane, jane X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 May 2018 09:16:14 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 8E2A9ACC0; Mon, 14 May 2018 09:16:12 +0000 (UTC) Date: Mon, 14 May 2018 09:33:00 -0000 From: Richard Biener To: Prathamesh Kulkarni cc: gcc Patches , Jan Hubicka Subject: Re: PR85734 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-SW-Source: 2018-05/txt/msg00596.txt.bz2 On Mon, 14 May 2018, Prathamesh Kulkarni wrote: > Hi, > The attached patch tries to fix PR85734, by gating on > !function_always_visible_to_compiler_p. > Bootstrap+test in progress on x86_64. > OK to commit if passes ? This looks redundant - suggest_attribute does that very same check but warn_function_malloc passes it 'false' as known_finite (warn_function_noreturn passes it true for example). So I suggest to simply pass true as that arg. Richard > Thanks, > Prathamesh > -- Richard Biener SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)