From: Richard Biener <rguenther@suse.de>
To: gcc-patches@gcc.gnu.org
Cc: Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH] Don't fold nextafter/nexttoward if -ftrapping-math or -fmath-errno if they produce denormal results (PR c/86420)
Date: Mon, 09 Jul 2018 09:49:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.20.1807091146180.16707@zhemvz.fhfr.qr> (raw)
In-Reply-To: <alpine.DEB.2.21.1807071132260.19203@stedding.saclay.inria.fr>
On Sat, 7 Jul 2018, Marc Glisse wrote:
> On Sat, 7 Jul 2018, Jakub Jelinek wrote:
>
> > 2018-07-07 Jakub Jelinek <jakub@redhat.com>
> >
> > PR c/86420
> > * real.c (real_nextafter): Return true if result is denormal.
>
> I have a question on the side: would it be hard / useful, in cases where
> nextafter may set errno or some exception flag, to fold the result to a
> constant while keeping the function call (ignoring the value it returns)? To
> clarify, I mean replace
>
> _2 = nextafter(DBL_DENORM_MIN, 0);
>
> with
>
> nextafter(DBL_DENORM_MIN, 0);
> _2 = 0;
>
> I think we already do that for some other calls, although I can't remember
> where. The point would be that we have the value of _2 and can keep folding
> its uses.
There's tree-call-dce.c which is doing a related (more complex) transform
but nothing doing constant propagation through calls. I think it would
be more useful for the target C library to expose sth like
set_errno (...) so we can constant fold the errno setting as well.
Maybe there's some cheap non-DCEable math function we could abuse...
Richard.
next prev parent reply other threads:[~2018-07-09 9:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-07 8:08 Jakub Jelinek
2018-07-07 9:55 ` Marc Glisse
2018-07-07 10:13 ` Jakub Jelinek
2018-07-07 11:31 ` Marc Glisse
2018-07-09 9:49 ` Richard Biener [this message]
2018-07-09 9:46 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1807091146180.16707@zhemvz.fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).