From: Richard Biener <rguenther@suse.de>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix PR88301
Date: Tue, 04 Dec 2018 13:17:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.20.1812041417060.1827@zhemvz.fhfr.qr> (raw)
In-Reply-To: <CAKdteOYvGr4aDu3sF78ANapj1+uJXmv2qoMr5AEvz0-wQW_2bA@mail.gmail.com>
On Tue, 4 Dec 2018, Christophe Lyon wrote:
> Hi Richard,
> On Mon, 3 Dec 2018 at 14:37, Richard Biener <rguenther@suse.de> wrote:
> >
> >
> > This fixes a missed optimization in EVRP by teaching the code
> > figuring out conditional asserts about conversions that preserve
> > the converted value.
> >
> > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk
> > sofar.
> >
> > Richard.
> >
> > 2018-12-03 Richard Biener <rguenther@suse.de>
> >
> > PR tree-optimization/88301
> > * tree-vrp.c (register_edge_assert_for_2): Handle conversions
> > that do not change the value by registering the same assert
> > for the operand.
> >
> > * gcc.dg/tree-ssa/evrp13.c: New testcase.
> >
>
> I noticed a regression in g++ on aarch64, and git bisect indicates
> this commits is the culprit.
> g++.dg/warn/Wstringop-overflow-1.C -std=c++14 (test for warnings, line 14)
> g++.dg/warn/Wstringop-overflow-1.C -std=c++14 (test for excess errors)
> g++.dg/warn/Wstringop-overflow-1.C -std=c++17 (test for warnings, line 14)
> g++.dg/warn/Wstringop-overflow-1.C -std=c++17 (test for excess errors)
> g++.dg/warn/Wstringop-overflow-1.C -std=c++98 (test for warnings, line 14)
> g++.dg/warn/Wstringop-overflow-1.C -std=c++98 (test for excess errors)
>
> g++.log says:
> Excess errors:
> /gcc/testsuite/g++.dg/warn/Wstringop-overflow-1.C:14:21: warning:
> 'char* __builtin_strncpy(char*, const char*, long unsigned int)'
> writing between 6 and 2147483647 bytes into a region of size 5
> overflows the destination [-Wstringop-overflow=]
Yes, sorry. r266773 should have fixed this.
Richard.
next prev parent reply other threads:[~2018-12-04 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 13:37 Richard Biener
2018-12-04 13:14 ` Christophe Lyon
2018-12-04 13:17 ` Richard Biener [this message]
2018-12-05 15:08 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1812041417060.1827@zhemvz.fhfr.qr \
--to=rguenther@suse.de \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).