From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74536 invoked by alias); 13 May 2019 10:33:47 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 74528 invoked by uid 89); 13 May 2019 10:33:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=wondering X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 May 2019 10:33:46 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4E20EAD7B; Mon, 13 May 2019 10:33:44 +0000 (UTC) Date: Mon, 13 May 2019 10:33:00 -0000 From: Richard Biener To: Segher Boessenkool cc: Jiufu Guo , Jeff Law , gcc-patches@gcc.gnu.org, jakub@redhat.com, dberlin@dberlin.org, wschmidt@linux.ibm.com Subject: Re: [PATCH] Eliminates phi on branch for CMP result In-Reply-To: <20190513102558.GU8599@gate.crashing.org> Message-ID: References: <1557152644-3063-1-git-send-email-guojiufu@linux.ibm.com> <20190507164253.GH8599@gate.crashing.org> <20190513102558.GU8599@gate.crashing.org> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-SW-Source: 2019-05/txt/msg00589.txt.bz2 On Mon, 13 May 2019, Segher Boessenkool wrote: > On Sun, May 12, 2019 at 10:07:28PM -0500, Jiufu Guo wrote: > > To elimiate the instructions which moving result of CMP to GPR, I'm > > wondering maybe we could do a combine(or a peephole) after bbro to let > > the condition jump directly using the result of CMP. > > It will have to be a peephole. And peepholes are machine-specific. > > You will also not get any further optimisations in those blocks, that way; > not combine etc. > > It really should be done on gimple, not rtl. Agreed.